core: fix stateroot height update for testnet #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master-2.x #1213 +/- ##
===========================================
Coverage 67.78% 67.78%
===========================================
Files 159 159
Lines 15611 15611
===========================================
Hits 10582 10582
Misses 4507 4507
Partials 522 522
Continue to review full report at Codecov.
|
When synchronizing with stateroot-enabled network from genesis and if stateroot is not enabled in block zero we were failing to update state height because initially it's updated with a jump from 0 to StateRootEnableIndex, so we should allow that to happen to have correct state height.
roman-khimov
force-pushed
the
fix-stateheight-sync-for-nonzero-enableindex
branch
from
9cf9c76
to
6d32751
Compare
We we missing stateroot for StateRootEnableIndex, starting only with StateRootEnableIndex + 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When synchronizing with stateroot-enabled network from genesis and if
stateroot is not enabled in block zero we were failing to update state height
because initially it's updated with a jump from 0 to StateRootEnableIndex, so
we should allow that to happen to have correct state height.