Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: return bse64 bytes from getblock, getblockheader, getrawtx #1525

Merged
merged 1 commit into from
Nov 9, 2020

Conversation

AnnaShaleva
Copy link
Member

Close #1522

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #1525 (6bb81d9) into master (bdd073a) will decrease coverage by 0.04%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1525      +/-   ##
==========================================
- Coverage   77.60%   77.55%   -0.05%     
==========================================
  Files         229      229              
  Lines       17942    17933       -9     
==========================================
- Hits        13923    13908      -15     
- Misses       3049     3052       +3     
- Partials      970      973       +3     
Impacted Files Coverage Δ
pkg/rpc/server/server.go 78.03% <66.66%> (ø)
pkg/rpc/client/rpc.go 83.64% <100.00%> (-2.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdd073a...6bb81d9. Read the comment docs.

pkg/rpc/client/rpc.go Outdated Show resolved Hide resolved
@roman-khimov roman-khimov merged commit a9dddf8 into master Nov 9, 2020
@roman-khimov roman-khimov deleted the rpc/base64 branch November 9, 2020 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert getrawtransaction/getblock to base64 output
2 participants