Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

payload: treat zero-length headers as error #1716

Merged
merged 1 commit into from
Feb 6, 2021
Merged

Conversation

roman-khimov
Copy link
Member

@roman-khimov roman-khimov added this to the v0.93.0 milestone Feb 5, 2021
@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #1716 (eecd71a) into master (aad2b3a) will increase coverage by 2.74%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1716      +/-   ##
==========================================
+ Coverage   79.60%   82.35%   +2.74%     
==========================================
  Files         255      255              
  Lines       21242    21245       +3     
==========================================
+ Hits        16910    17496     +586     
+ Misses       3216     2652     -564     
+ Partials     1116     1097      -19     
Impacted Files Coverage Δ
pkg/network/payload/headers.go 100.00% <100.00%> (ø)
pkg/consensus/consensus.go 69.96% <0.00%> (-0.61%) ⬇️
pkg/vm/vm.go 93.96% <0.00%> (+0.57%) ⬆️
pkg/vm/stackitem/item.go 90.84% <0.00%> (+0.72%) ⬆️
pkg/core/interop/context.go 95.71% <0.00%> (+2.85%) ⬆️
pkg/vm/interop.go 83.58% <0.00%> (+2.98%) ⬆️
pkg/vm/context.go 90.72% <0.00%> (+3.09%) ⬆️
pkg/compiler/compiler.go 58.71% <0.00%> (+3.66%) ⬆️
pkg/compiler/analysis.go 96.72% <0.00%> (+9.01%) ⬆️
pkg/compiler/types.go 76.19% <0.00%> (+11.90%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aad2b3a...eecd71a. Read the comment docs.

@roman-khimov roman-khimov merged commit 66471de into master Feb 6, 2021
@roman-khimov roman-khimov deleted the zero-headers-error branch February 6, 2021 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants