Add header back #2259
Merged
Add header back #2259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 22, 2021 13:53
erikzhang
reviewed
Jan 22, 2021
added 2 commits
January 22, 2021 16:53
erikzhang
reviewed
Jan 22, 2021
|
@erikzhang @shargon Could you have a look at this? |
|
Should be able to switch between modes (index/headers) by configuration? |
added 2 commits
January 25, 2021 18:25
I think headers and index do not conflict. We can synchronize headers first, and then synchronize blocks by index. |
erikzhang
reviewed
Jan 25, 2021
vncoelho
reviewed
Jan 25, 2021
|
Why to return with it? |
|
Tested failed with memory store, consensus not work:
|
added 2 commits
January 26, 2021 16:34
Fixed |
added 2 commits
January 26, 2021 16:41
shargon
reviewed
Jan 26, 2021
erikzhang
reviewed
Feb 2, 2021
|
The code looks good now. |
|
@erikzhang Please have a check |
added 4 commits
February 2, 2021 19:55
|
Test commit: 9d8057b It works and the sync time is acceptable.
|
erikzhang
reviewed
Feb 2, 2021
This reverts commit 9d8057b.
erikzhang
reviewed
Feb 3, 2021
Co-authored-by: Erik Zhang <erik@neo.org>
|
@ProDog Could you have one more test? |
erikzhang
approved these changes
Feb 3, 2021
|
Block time interval 10ms, it works good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially reverse #1397