Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli/wallet: show tx fee before relaying #2180

Merged
merged 1 commit into from
Sep 22, 2021
Merged

cli/wallet: show tx fee before relaying #2180

merged 1 commit into from
Sep 22, 2021

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Sep 15, 2021

Fix #2175 .
Signed-off-by: Evgeniy Stratonikov evgeniy@nspcc.ru

Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need it for contract invocations (where we have --force already and it's OK to make this flag change fee behavior).

cli/wallet/wallet.go Outdated Show resolved Hide resolved
cli/wallet/wallet.go Outdated Show resolved Hide resolved
cli/wallet/wallet.go Outdated Show resolved Hide resolved
cli/wallet/nep17.go Outdated Show resolved Hide resolved
cli/candidate_test.go Show resolved Hide resolved
@AnnaShaleva
Copy link
Member

And TestNEP17Transfer's regexp for network fee should be updated to a human-readable format.

Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>
@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #2180 (2a78ec8) into master (56dd7b7) will increase coverage by 0.00%.
The diff coverage is 76.92%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2180   +/-   ##
=======================================
  Coverage   83.74%   83.75%           
=======================================
  Files         295      295           
  Lines       28239    28264   +25     
=======================================
+ Hits        23650    23673   +23     
- Misses       3247     3249    +2     
  Partials     1342     1342           
Impacted Files Coverage Δ
cli/wallet/nep11.go 78.43% <0.00%> (-1.19%) ⬇️
cli/smartcontract/smart_contract.go 89.28% <75.00%> (-0.21%) ⬇️
cli/input/input.go 52.77% <100.00%> (+18.16%) ⬆️
cli/wallet/nep17.go 75.97% <100.00%> (+0.25%) ⬆️
pkg/services/notary/notary.go 92.85% <0.00%> (+0.79%) ⬆️
pkg/network/discovery.go 98.58% <0.00%> (+1.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56dd7b7...2a78ec8. Read the comment docs.

@roman-khimov roman-khimov merged commit d915f08 into master Sep 22, 2021
@roman-khimov roman-khimov deleted the cli-show-fee branch September 22, 2021 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show/confirm GAS spent for fees in CLI
3 participants