core: don't sort witnesses prior to check, fix #2301 #2302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8537700 was a bit wrong in its witness treatment, contract-based verification scripts have zero length and this script has a hash different from the target script hash to check, so sorting can break witnesses in some cases.
AnnaShaleva
approved these changes
Dec 7, 2021
|
Have you tested whether the tx from the issue passes the VM now? |
|
I guess we need to say hi to neo-project/neo#938 again. |
roman-khimov
added a commit
that referenced
this pull request
Dec 7, 2021
A follow-up to #2302, sort hashes using reverse order. Fixes f9c68613f41ca85ddb01ec757153c0d86018d2324f6ff85a4afc708bb598b722 validation. Hi, neo-project/neo#938.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
8537700 was a bit wrong in its witness
treatment, contract-based verification scripts have zero length and this
script has a hash different from the target script hash to check, so sorting
can break witnesses in some cases.