Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util: reverse the order of uint160 comparsion #2303

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

roman-khimov
Copy link
Member

A follow-up to #2302, sort hashes using reverse order. Fixes
f9c68613f41ca85ddb01ec757153c0d86018d2324f6ff85a4afc708bb598b722 validation.

Hi, neo-project/neo#938.

A follow-up to #2302, sort hashes using reverse order. Fixes
f9c68613f41ca85ddb01ec757153c0d86018d2324f6ff85a4afc708bb598b722 validation.

Hi, neo-project/neo#938.
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch.

@roman-khimov
Copy link
Member Author

Just for the record, verifyTxWitnesses() is the only user of (Uint160) Less(Uint160) bool.

@roman-khimov roman-khimov added this to the v0.78.5 milestone Dec 7, 2021
@roman-khimov roman-khimov merged commit fae1d56 into master-2.x Dec 7, 2021
@roman-khimov roman-khimov deleted the fix-uint160-sort-order branch December 7, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants