Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: several Notary subsystem adjustments, part 1 #2378

Merged
merged 5 commits into from
Mar 2, 2022

Conversation

AnnaShaleva
Copy link
Member

Changes should be in sync with neo-project/neo#2661 and neo-project/neo-modules#691.

@AnnaShaleva AnnaShaleva force-pushed the notary-adjustments branch 2 times, most recently from 24cf239 to ff4b2a3 Compare March 1, 2022 13:57
pkg/core/native/notary.go Outdated Show resolved Hide resolved
pkg/core/native/notary.go Outdated Show resolved Hide resolved
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be split into two PRs: one that we can merge immediately (everything related to NotaryServiceFeePerKey and fixes) and one that'd be postponed until final agreement is reached (IDs mostly, but withdrawal changes too).

pkg/rpc/client/native.go Show resolved Hide resolved
pkg/core/native/notary.go Outdated Show resolved Hide resolved
pkg/interop/native/notary/notary.go Outdated Show resolved Hide resolved
pkg/core/native/notary.go Outdated Show resolved Hide resolved
@AnnaShaleva AnnaShaleva force-pushed the notary-adjustments branch 5 times, most recently from 1cc3963 to 78f2998 Compare March 1, 2022 15:32
@AnnaShaleva AnnaShaleva changed the title *: several Notary subsystem adjustments *: several Notary subsystem adjustments, part 1 Mar 1, 2022
@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #2378 (992d74d) into master (8ac2658) will increase coverage by 0.09%.
The diff coverage is 90.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2378      +/-   ##
==========================================
+ Coverage   84.87%   84.97%   +0.09%     
==========================================
  Files         290      290              
  Lines       35930    36050     +120     
==========================================
+ Hits        30496    30632     +136     
+ Misses       4143     4119      -24     
- Partials     1291     1299       +8     
Impacted Files Coverage Δ
pkg/core/transaction/notary_assisted.go 100.00% <ø> (ø)
pkg/rpc/client/rpc.go 81.18% <40.00%> (-0.31%) ⬇️
pkg/rpc/client/native.go 69.15% <57.14%> (-1.14%) ⬇️
pkg/core/native/native_nep17.go 86.61% <60.00%> (-0.57%) ⬇️
pkg/compiler/compiler.go 72.55% <70.00%> (-0.32%) ⬇️
pkg/compiler/debug.go 93.02% <97.64%> (+0.68%) ⬆️
cli/smartcontract/generate.go 83.33% <100.00%> (ø)
cli/smartcontract/smart_contract.go 92.53% <100.00%> (+0.04%) ⬆️
pkg/compiler/codegen.go 92.43% <100.00%> (ø)
pkg/compiler/inline.go 96.51% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b76ed...992d74d. Read the comment docs.

@AnnaShaleva AnnaShaleva marked this pull request as ready for review March 1, 2022 16:23
@roman-khimov roman-khimov merged commit ff60571 into master Mar 2, 2022
@roman-khimov roman-khimov deleted the notary-adjustments branch March 2, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants