*: several Notary subsystem adjustments, part 2

[AnnaShaleva]

Waiting for the final decision on constants/limits.

Depends on #2378.

TODO:

• Update interop dependencies right before the merge.

[roman-khimov]

Can we rebase it to see the current list of remaining changes?

[AnnaShaleva]

Can we rebase it to see the current list of remaining changes?

Yes, but I found one more bug in snapshot isolation and trying to test it for the C# node. After that I'll rebase it.

[AnnaShaleva]

@roman-khimov, speaking of valuable constants:

• P2PNotaryRequestType payload type is still set to 0x50 (Add a notary service neo-project/neo#2661 (comment))
• P2PNotary node role is still set to 128 (Add a notary service neo-project/neo#2661 (comment) and Add a notary service neo-project/neo#2661 (comment)).

Speaking of the PR logic:

• Notary deposit withdrawal is performed in two steps (Mint + Burn) (Add a notary service neo-project/neo#2661 (comment)).

Maybe there's something else, I'll review the reference PR one more time.

[roman-khimov]

valuable constants:

Yeah, these can be very problematic long-term even though they're trivial to set once and forget. Thanks for raising this once again.

Notary deposit withdrawal is performed in two steps (Mint + Burn)

I'm sure it can and should be fixed. But it's not critical for long-term compatibility at the same time.

[codecov]

Codecov Report

Merging #2380 (808d8a2) into master (ebc3974) will decrease coverage by 0.07%.
The diff coverage is 61.17%.

@@            Coverage Diff             @@
##           master    #2380      +/-   ##
==========================================
- Coverage   85.11%   85.03%   -0.08%     
==========================================
  Files         294      295       +1     
  Lines       37079    37097      +18     
==========================================
- Hits        31559    31545      -14     
- Misses       4193     4210      +17     
- Partials     1327     1342      +15     

Impacted Files	Coverage Δ
cli/smartcontract/generate.go	83.33% <ø> (ø)
cli/smartcontract/smart_contract.go	92.53% <ø> (ø)
pkg/compiler/compiler.go	74.60% <ø> (ø)
pkg/config/config.go	82.35% <ø> (ø)
pkg/core/native/contract.go	100.00% <ø> (ø)
pkg/core/transaction/attrtype.go	100.00% <ø> (ø)
pkg/services/notary/notary.go	84.69% <ø> (-0.98%)	⬇️
pkg/vm/vm.go	93.34% <42.85%> (-0.80%)	⬇️
pkg/vm/stackitem/item.go	88.19% <43.75%> (-2.40%)	⬇️
cli/smartcontract/permission.go	91.20% <81.25%> (ø)
... and 12 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1607e2...808d8a2. Read the comment docs.