-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rpcclient: expose endpoint (fixes #2912) #2915
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2915 +/- ##
==========================================
+ Coverage 84.98% 85.07% +0.08%
==========================================
Files 329 329
Lines 42325 42327 +2
==========================================
+ Hits 35970 36009 +39
+ Misses 4890 4851 -39
- Partials 1465 1467 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I don't know what's wrong with the lint job as I don't see any issues locally with the files I modified
the same files are reported on master
|
OK for me, can you squash these commits? |
Yes, GH squash creates nonsense commit messages most of the time. I do care a lot about commits having clear scope and descriptive messages, my expectations with respect to that are somewhat close to the way patches are handled in Linux (https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/5.Posting.rst#n60). Github is not very friendly to this workflow, unfortunately (unlike Gitlab, for example, that handles rebases much better allowing to diff versions or rebased PR), but clear commit history is too important. So we create a set of proper commits (this one is very simple, so it only require one patch) in PRs and then merge them. |
You can edit the commit message before merging (similar to an interactive rebase). The only difference is you need to do it (and not forget to delete random messages) instead of the PR author. Anyway, I combined the commits and will have a look at your link. Thanks! |
Problem
Endpoint data not accessible
Solution
expose with method as string as per #2912 (comment)