Close notification channels on wsclient disconnect #2980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsReader() closes c.done first and then goes over the list of c.respChannels. Technically this means that any of the two can be taken in this select. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Codecov Report
@@ Coverage Diff @@
## master #2980 +/- ##
==========================================
- Coverage 84.88% 84.78% -0.11%
==========================================
Files 328 328
Lines 43047 43059 +12
==========================================
- Hits 36541 36506 -35
- Misses 5023 5068 +45
- Partials 1483 1485 +2
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AnnaShaleva
reviewed
Apr 19, 2023
roman-khimov
force-pushed
the
close-notification-chans-on-wsclient-disconnect
branch
from
3458d46
to
1a1196f
Compare
AnnaShaleva
previously approved these changes
Apr 19, 2023
AnnaShaleva
reviewed
Apr 19, 2023
roman-khimov
force-pushed
the
close-notification-chans-on-wsclient-disconnect
branch
from
1a1196f
to
790e657
Compare
AnnaShaleva
reviewed
Apr 19, 2023
The reader is about to exit and it will close legacy c.Notifications, but it will leave subscription channels at the same time. This is wrong since these channels will no longer receive any new events, game over. Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
force-pushed
the
close-notification-chans-on-wsclient-disconnect
branch
from
790e657
to
6eaa765
Compare
AnnaShaleva
approved these changes
Apr 19, 2023
roman-khimov
deleted the
close-notification-chans-on-wsclient-disconnect
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.