Fix timeout of RPC tests on Windows #3165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnnaShaleva
force-pushed
the
fix-win-timeout
branch
from
6295c76
to
350ea81
Compare
AnnaShaleva
force-pushed
the
fix-win-timeout
branch
from
350ea81
to
c93658b
Compare
|
@roman-khimov, let's merge it and keep watching our tests. At least, this PR doesn't make things worse. |
Codecov Report
@@ Coverage Diff @@
## master #3165 +/- ##
==========================================
+ Coverage 85.35% 85.37% +0.02%
==========================================
Files 323 326 +3
Lines 43603 43773 +170
==========================================
+ Hits 37217 37372 +155
- Misses 4921 4926 +5
- Partials 1465 1475 +10
... and 17 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Merged
roman-khimov
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. #2975.
Here's the example of successful run: https://github.com/nspcc-dev/neo-go/actions/runs/6562296558/job/17823936017. I'll run it a couple of times to ensure that the problem is gone before the merge. Thus, currently is in draft.
Just for the record, an alternative to this PR was a Dialler fix at 6ec8126. I've also considered to enable IPv6 on our Windonws GA runner, but it's not possible at the current moment due to GitHub infrastructure constraints, see the actions/runner-images#668.