Fix linter problems #3171
Merged
Fix linter problems #3171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the following linter warning: ``` indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (move short variable declaration to its own line if necessary) (revive) ``` Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Fix the following linter warning: ``` dot-imports: should not use dot imports (revive) ``` Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Disable the following linter warning: ``` superfluous-else: if block ends with call to panic function, so drop this else and outdent its block (revive) ``` Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
roman-khimov
approved these changes
Oct 20, 2023
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
force-pushed
the
fix-linter
branch
from
2c86975
to
7a6b908
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably, the Linter job was updated, and there are a set of linter warnings discovered in #3165 Lint job run.