Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vm: allow to emit any based on its type #3237

Merged
merged 1 commit into from
Nov 28, 2023
Merged

vm: allow to emit any based on its type #3237

merged 1 commit into from
Nov 28, 2023

Conversation

AnnaShaleva
Copy link
Member

No functional changes, just moved a part of emit.Array to a separate exported method. It may be useful for contract-based witness invocation scripts construction and not only. Ref.
#3233 (comment).

@AnnaShaleva AnnaShaleva added the vm VM tasks/bugs/issues label Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (2f9b4a2) 85.31% compared to head (3db8da7) 85.39%.
Report is 3 commits behind head on master.

❗ Current head 3db8da7 differs from pull request most recent head b637048. Consider uploading reports for the commit b637048 to get more accurate results

Files Patch % Lines
pkg/vm/emit/emit.go 90.76% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3237      +/-   ##
==========================================
+ Coverage   85.31%   85.39%   +0.08%     
==========================================
  Files         327      327              
  Lines       44081    44084       +3     
==========================================
+ Hits        37606    37645      +39     
+ Misses       4993     4956      -37     
- Partials     1482     1483       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/vm/emit/emit.go Outdated Show resolved Hide resolved
pkg/vm/emit/emit.go Outdated Show resolved Hide resolved
@AnnaShaleva AnnaShaleva changed the title vm: allow to emit something based on its type vm: allow to emit any based on its type Nov 28, 2023
No functional changes, just moved a part of emit.Array to a separate
exported method. It may be useful for contract-based witness invocation
scripts construction and not only. Ref.
#3233 (comment).

Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
@roman-khimov roman-khimov merged commit 98de5b9 into master Nov 28, 2023
12 of 16 checks passed
@roman-khimov roman-khimov deleted the emit-smth branch November 28, 2023 15:01
@roman-khimov roman-khimov added this to the v0.105.0 milestone Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vm VM tasks/bugs/issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants