neotest: Add contract signer support #3233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepanovdmitrii
requested review from
AnnaShaleva and
roman-khimov
as code owners
AnnaShaleva
reviewed
Nov 28, 2023
|
Just as an idea --- can we reuse a local client in |
I like this idea, but even with RPC-based network fee calculation in neotest I still think that it might be a good point to implement contract signer so that it would be easier to construct contract-based witnesses. |
AnnaShaleva
added a commit
that referenced
this pull request
Nov 28, 2023
No functional changes, just moved a part of emit.Array to a separate exported method. It may be useful for contract-based witness invocation scripts construction and not only. Ref. #3233 (comment). Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
that referenced
this pull request
Nov 28, 2023
No functional changes, just moved a part of emit.Array to a separate exported method. It may be useful for contract-based witness invocation scripts construction and not only. Ref. #3233 (comment). Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
that referenced
this pull request
Nov 28, 2023
No functional changes, just moved a part of emit.Array to a separate exported method. It may be useful for contract-based witness invocation scripts construction and not only. Ref. #3233 (comment). Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
added a commit
that referenced
this pull request
Nov 28, 2023
No functional changes, just moved a part of emit.Array to a separate exported method. It may be useful for contract-based witness invocation scripts construction and not only. Ref. #3233 (comment). Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
stepanovdmitrii
force-pushed
the
feat/neotest_contract_signer_support
branch
from
d0dd4dc
to
2f960fc
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3233 +/- ##
==========================================
- Coverage 85.34% 85.25% -0.09%
==========================================
Files 327 327
Lines 44084 44144 +60
==========================================
+ Hits 37622 37635 +13
- Misses 4983 5020 +37
- Partials 1479 1489 +10 ☔ View full report in Codecov by Sentry. |
AnnaShaleva
reviewed
Dec 1, 2023
This was referenced Dec 1, 2023
roman-khimov
reviewed
Dec 1, 2023
Signed-off-by: Dmitrii Stepanov <dima-stepan@yandex.ru>
stepanovdmitrii
force-pushed
the
feat/neotest_contract_signer_support
branch
from
2f960fc
to
7b53a0c
Compare
AnnaShaleva
approved these changes
Dec 1, 2023
fyfyrchik
added a commit
to fyfyrchik/neo-go
that referenced
this pull request
Dec 8, 2023
Refs nspcc-dev#3245 Refs nspcc-dev#3233 Signed-off-by: Evgenii Stratonikov <fyfyrchik@runbox.com>
fyfyrchik
added a commit
to fyfyrchik/neo-go
that referenced
this pull request
Dec 8, 2023
Refs nspcc-dev#3245 Refs nspcc-dev#3233 Signed-off-by: Evgenii Stratonikov <fyfyrchik@runbox.com>
fyfyrchik
added a commit
to fyfyrchik/neo-go
that referenced
this pull request
Dec 21, 2023
Refs nspcc-dev#3245 Refs nspcc-dev#3233 Signed-off-by: Evgenii Stratonikov <fyfyrchik@runbox.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using another contract for verification in unit tests, the transaction cost is calculated incorrectly.
...
Solution
To calculate the transaction cost, a test neo-vm is started on which the verification is performed.
...