Various verification fixes 2 #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-khimov
force-pushed
the
various-verification-fixes2
branch
2 times, most recently
from
8303426
to
97bce52
Compare
Codecov Report
@@ Coverage Diff @@
## master #417 +/- ##
==========================================
- Coverage 51.27% 51.04% -0.24%
==========================================
Files 96 97 +1
Lines 6487 6585 +98
==========================================
+ Hits 3326 3361 +35
- Misses 2922 2982 +60
- Partials 239 242 +3
Continue to review full report at Codecov.
|
volekerb
reviewed
Oct 4, 2019
volekerb
reviewed
Oct 4, 2019
volekerb
reviewed
Oct 4, 2019
volekerb
reviewed
Oct 4, 2019
volekerb
reviewed
Oct 4, 2019
volekerb
reviewed
Oct 4, 2019
volekerb
reviewed
Oct 4, 2019
volekerb
reviewed
Oct 4, 2019
volekerb
reviewed
Oct 4, 2019
volekerb
approved these changes
Oct 4, 2019
Fixes script invocations via the APPCALL instruction. Adjust contract state field types accordingly.
The same way C# node does.
This is an opaque data item that is to be used by the interop functions.
This is both for #373 and for interop functions that have to check some inputs.
This function is intended to be ran outside of the execute's panic recovery mechanism, so it shouldn't panic if there is no result.
Switch cases are evaluated sequentially and the fault case is top-priority to handle.
It gives access to the internal value's Value() which is essential for interop functions that need to get something from InteropItems. And it also simplifies some already existing code along the way.
Interop services routinely push such things (block index, blockchain height) onto the stack.
Script can return non-bool results that can still be converted to bool according to the usual VM rules. Unfortunately Bool() panics if this conversion fails which is OK for things done in vm.execute(), but certainly not for VerifyWitnesses(), thus there is a need for TryBool() that will just return an error in this case.
Make Context.Next() return both opcode and instruction parameter if any. This simplifies some code and needed to deal with #295.
Fix #295, deduplicate code and add `inspect` parameter to the vm command to dump AVMs (`contract inspect` works with Go code).
roman-khimov
force-pushed
the
various-verification-fixes2
branch
from
97bce52
to
dca332f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This focuses on VM improvements necessary to make tx verification work. It's mostly related to interop functionality, but doesn't add interops at the moment (I want to add more of them before the first push). Fixes #295 along the way.