Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notifications and getreferences bugs #499

Merged
merged 5 commits into from
Nov 15, 2019

Conversation

roman-khimov
Copy link
Member

Problem

#454, #453.

Solution

"Merge" button.

Fixes #453 and makes it possible to refer to these notifications later.
It's way more convenient for different purposes.
Ranging over map is nondeterministic and contracts may be unprepared for
that. Fixes #454.
@roman-khimov roman-khimov force-pushed the fix-notifications-and-getreferences-bugs branch from 7f46957 to a16c2c3 Compare November 15, 2019 15:05
@codecov
Copy link

codecov bot commented Nov 15, 2019

Codecov Report

Merging #499 into master will decrease coverage by 0.35%.
The diff coverage is 12.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #499      +/-   ##
==========================================
- Coverage   53.41%   53.06%   -0.36%     
==========================================
  Files         116      117       +1     
  Lines        8529     8592      +63     
==========================================
+ Hits         4556     4559       +3     
- Misses       3644     3704      +60     
  Partials      329      329
Impacted Files Coverage Δ
pkg/core/storage/store.go 37.5% <ø> (ø) ⬆️
pkg/core/blockchain.go 38.7% <0%> (-1.46%) ⬇️
pkg/core/notification_event.go 0% <0%> (ø)
pkg/core/interop_neo.go 0% <0%> (ø) ⬆️
pkg/vm/stack.go 87.69% <0%> (-0.91%) ⬇️
pkg/core/interop_system.go 0% <0%> (ø) ⬆️
pkg/vm/stack_item.go 62.58% <0%> (ø) ⬆️
pkg/core/interops.go 100% <100%> (ø) ⬆️
pkg/vm/serialization.go 95.4% <100%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9134cc1...a16c2c3. Read the comment docs.

@volekerb volekerb merged commit 2679d3f into master Nov 15, 2019
@volekerb volekerb deleted the fix-notifications-and-getreferences-bugs branch November 15, 2019 16:11
roman-khimov added a commit that referenced this pull request Feb 7, 2021
See neo-project/neo-modules/#499.
roman-khimov added a commit that referenced this pull request Feb 7, 2021
See neo-project/neo-modules/#499.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants