Network queues #606
Merged
Network queues #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Jan 17, 2020
roman-khimov
force-pushed
the
network-queues
branch
from
e84a713
to
cc3a4ea
Compare
golangcibot
reviewed
Jan 17, 2020
Codecov Report
@@ Coverage Diff @@
## master #606 +/- ##
==========================================
+ Coverage 63.42% 63.56% +0.13%
==========================================
Files 125 122 -3
Lines 10251 10125 -126
==========================================
- Hits 6502 6436 -66
+ Misses 3450 3384 -66
- Partials 299 305 +6
Continue to review full report at Codecov.
|
roman-khimov
force-pushed
the
network-queues
branch
from
cc3a4ea
to
b1a0bc6
Compare
fyrchik
suggested changes
Jan 17, 2020
roman-khimov
force-pushed
the
network-queues
branch
from
b1a0bc6
to
549b85c
Compare
fyrchik
reviewed
Jan 19, 2020
|
@roman-khimov @im-kulikov Have you already done benchmarks with this version? |
|
@fyrchik nope |
|
To be fair, I don't think it will change benchmark results a lot, but who knows. |
roman-khimov
force-pushed
the
network-queues
branch
from
549b85c
to
3c055e2
Compare
As they're directly tied to it.
It should always signal to the server, not duplicating this send and not missing it like it happened in the Server.run().
It's internal state of the peer that no one should care about.
Two queues for high-priority and ordinary messages. Fixes #590. These queues are deliberately made small to avoid buffer bloat problem, there is gonna be another queueing layer above them to compensate for that. The queues are designed to be synchronous in enqueueing, async capabilities are to be added layer above later.
fyrchik
approved these changes
Jan 20, 2020
im-kulikov
approved these changes
Jan 20, 2020
roman-khimov
force-pushed
the
network-queues
branch
from
3c055e2
to
0ba6b2a
Compare
|
OK, I've pushed just the rebased original patches here, so I think they're reviewed enough already to merge (and to fix #590). Newer patches (and I have a queue of them already) are gonna be pushed to the new branch for proper review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#590 and some other bugs.
Solution
This is an initial version that just solves the #590. We need to expand it later with more complex gossiping logic (we have broadcasting instead of that now everywhere).