Claim and enrollment TX verification fixes #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That should be done for Enrollment transactions.
We don't need a pointer here and this change makes this field compatible with Transaction.Inputs which is useful in many scenarios.
Everywhere in this code prevHash == input.PrevHash, thus we can easily move some common code out of the loop saving on DB accesses and serialization/deserialization.
prevHash == input.PrevHash, so make less DB accesses and more real work. Fix some bugs along the way: * spentCoins structure may already be present in the DB when persisting TX, there is nothing wrong with that and we shouldn't overwrite it * it's only used for NEO and only to check for claim validity. Thus, when processing claim tx the corresponding spentCoins should always be present in the DB
golangcibot
reviewed
Feb 27, 2020
Codecov Report
@@ Coverage Diff @@
## master #696 +/- ##
==========================================
+ Coverage 65.73% 65.75% +0.02%
==========================================
Files 128 128
Lines 10827 10883 +56
==========================================
+ Hits 7117 7156 +39
- Misses 3432 3450 +18
+ Partials 278 277 -1
Continue to review full report at Codecov.
|
Which allows to use it for ClaimTX. Make it also a bit more efficient as maps are expensive.
We don't need a map here, use simpler structures.
roman-khimov
force-pushed
the
tx-verification-fixes
branch
from
041002e
to
a074aeb
Compare
fyrchik
approved these changes
Feb 27, 2020
…etter Claim transactions should _add_ claims scripthashes to the standard list, not replace them. And this code is actually very reusable.
Refactor HaveInputsDuplicate() out of the core and Blockchain, it doesn't depend on the Blockchain state. Make it more efficient.
Add doesn't change the variable state. Thanks to GolangCI for catching this.
roman-khimov
force-pushed
the
tx-verification-fixes
branch
from
a074aeb
to
00d199e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Missing some checks for these transactions. Broken SpentCoin tracking logic.