-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Claim and enrollment TX verification fixes #696
Commits on Feb 21, 2020
-
core: add validator public key into the list of hashes to verify
That should be done for Enrollment transactions.
Configuration menu - View commit details
-
Copy full SHA for d5e6028 - Browse repository at this point
Copy the full SHA d5e6028View commit details
Commits on Feb 24, 2020
-
transaction: strip off a layer of redirection from ClaimTX.Claims
We don't need a pointer here and this change makes this field compatible with Transaction.Inputs which is useful in many scenarios.
Configuration menu - View commit details
-
Copy full SHA for 5c96815 - Browse repository at this point
Copy the full SHA 5c96815View commit details -
core: put unspents get/put one loop above in storeBlock
Everywhere in this code prevHash == input.PrevHash, thus we can easily move some common code out of the loop saving on DB accesses and serialization/deserialization.
Configuration menu - View commit details
-
Copy full SHA for 36c6b6a - Browse repository at this point
Copy the full SHA 36c6b6aView commit details
Commits on Feb 25, 2020
-
core: move spent coin management out of the inner storeBlock loop
prevHash == input.PrevHash, so make less DB accesses and more real work. Fix some bugs along the way: * spentCoins structure may already be present in the DB when persisting TX, there is nothing wrong with that and we shouldn't overwrite it * it's only used for NEO and only to check for claim validity. Thus, when processing claim tx the corresponding spentCoins should always be present in the DB
Configuration menu - View commit details
-
Copy full SHA for c258adb - Browse repository at this point
Copy the full SHA c258adbView commit details
Commits on Feb 27, 2020
-
transaction: unbind GroupInputsByPrevHash from Transaction
Which allows to use it for ClaimTX. Make it also a bit more efficient as maps are expensive.
Configuration menu - View commit details
-
Copy full SHA for 80de208 - Browse repository at this point
Copy the full SHA 80de208View commit details -
core/transaction: use new transaction.InOut for References
We don't need a map here, use simpler structures.
Configuration menu - View commit details
-
Copy full SHA for 9f70185 - Browse repository at this point
Copy the full SHA 9f70185View commit details -
core: drop GetScriptHashesForVerifyingClaim, fix Claim's ScriptHash g…
…etter Claim transactions should _add_ claims scripthashes to the standard list, not replace them. And this code is actually very reusable.
Configuration menu - View commit details
-
Copy full SHA for 9b1ad40 - Browse repository at this point
Copy the full SHA 9b1ad40View commit details -
core: add duplicate Claim verification check
Refactor HaveInputsDuplicate() out of the core and Blockchain, it doesn't depend on the Blockchain state. Make it more efficient.
Configuration menu - View commit details
-
Copy full SHA for 29586f2 - Browse repository at this point
Copy the full SHA 29586f2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7bea6e0 - Browse repository at this point
Copy the full SHA 7bea6e0View commit details -
core: fix NetworkFee calculation
Add doesn't change the variable state. Thanks to GolangCI for catching this.
Configuration menu - View commit details
-
Copy full SHA for 00d199e - Browse repository at this point
Copy the full SHA 00d199eView commit details