Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consensus: partial consensus message decoding #862

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

AnnaShaleva
Copy link
Member

@AnnaShaleva AnnaShaleva commented Apr 16, 2020

closes #849

@AnnaShaleva AnnaShaleva added the consensus dBFT consensus label Apr 16, 2020
@AnnaShaleva AnnaShaleva self-assigned this Apr 16, 2020
@AnnaShaleva
Copy link
Member Author

Also checked on privnet

@codecov
Copy link

codecov bot commented Apr 16, 2020

Codecov Report

Merging #862 into master-2.x will decrease coverage by 0.00%.
The diff coverage is 76.19%.

Impacted file tree graph

@@              Coverage Diff               @@
##           master-2.x     #862      +/-   ##
==============================================
- Coverage       67.86%   67.86%   -0.01%     
==============================================
  Files             142      142              
  Lines           13422    13433      +11     
==============================================
+ Hits             9109     9116       +7     
- Misses           3897     3900       +3     
- Partials          416      417       +1     
Impacted Files Coverage Δ
pkg/consensus/consensus.go 40.44% <16.66%> (-0.62%) ⬇️
pkg/consensus/payload.go 97.43% <100.00%> (+0.12%) ⬆️
pkg/consensus/recovery_message.go 84.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84edcf0...c813873. Read the comment docs.

@roman-khimov roman-khimov added this to the v0.75.0 milestone Apr 16, 2020
@roman-khimov
Copy link
Member

closes #859

Really?

@roman-khimov roman-khimov merged commit 24675d0 into master-2.x Apr 16, 2020
@roman-khimov roman-khimov deleted the neo2x/partial_consensus_message_decoding branch April 16, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus dBFT consensus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants