consensus: added partial message decoding

[AnnaShaleva]

closes #849

[roman-khimov]

Maybe something like

if p.message != nil {
    ww := io.NewBufBinWriter()
    p.message.EncodeBinary(ww.BinWriter)
    p.data = ww.Bytes()
}
w.WriteVarBytes(p.data)

And then you don't need to update p.data in every Set method.

[codecov]

Codecov Report

Merging #859 into master will increase coverage by 0.00%.
The diff coverage is 78.94%.

@@           Coverage Diff           @@
##           master     #859   +/-   ##
=======================================
  Coverage   63.43%   63.43%           
=======================================
  Files         183      183           
  Lines       15733    15744   +11     
=======================================
+ Hits         9980     9987    +7     
- Misses       5272     5275    +3     
- Partials      481      482    +1     

Impacted Files	Coverage Δ
pkg/consensus/consensus.go	39.61% <0.00%> (-0.62%)	⬇️
pkg/consensus/payload.go	97.43% <100.00%> (+0.12%)	⬆️
pkg/consensus/recovery_message.go	84.33% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e3c364...9dd5ab5. Read the comment docs.

[roman-khimov]

We also need to fix dbft.WithNewConsensusPayload() invocation.

[AnnaShaleva]

We also need to fix dbft.WithNewConsensusPayload() invocation.

Did you mean

dbft.WithNewConsensusPayload(func() payload.ConsensusPayload { p := new(Payload); p.message = &message{}; return p }),

?

[roman-khimov]

Yep, p.message was obviously uninitialized there and dbft library will use p.message for its purposes.