Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support subnet attributes in NodeInfo #356

Closed
3 tasks
cthulhu-rider opened this issue Nov 16, 2021 · 0 comments · Fixed by #359
Closed
3 tasks

Support subnet attributes in NodeInfo #356

cthulhu-rider opened this issue Nov 16, 2021 · 0 comments · Fixed by #359
Assignees
@cthulhu-rider
Labels
enhancement Improving existing functionality
Milestone
v2.11.0

Comments

@cthulhu-rider
Copy link
Contributor

cthulhu-rider commented Nov 16, 2021 •
edited
Loading

Task
@cthulhu-rider cthulhu-rider added the enhancement Improving existing functionality label Nov 16, 2021
@cthulhu-rider cthulhu-rider added this to the v1.30 milestone Nov 16, 2021
@cthulhu-rider cthulhu-rider mentioned this issue Nov 16, 2021
Closed
3 tasks
@cthulhu-rider cthulhu-rider modified the milestones: v1.30, v1.31.0 Nov 16, 2021
@cthulhu-rider cthulhu-rider mentioned this issue Nov 17, 2021
Closed
@cthulhu-rider cthulhu-rider self-assigned this Nov 17, 2021
@cthulhu-rider cthulhu-rider mentioned this issue Nov 17, 2021
Merged
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api-go that referenced this issue Nov 18, 2021
[nspcc-dev#356] refs: Add functions to work with zero subnet
31c6451 
Add helper functions which provide ease of use with subnet zero IDs.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api-go that referenced this issue Nov 18, 2021
[nspcc-dev#356] refs: Implement text encoding of SubnetID
9d60c92 
Implement `encoding.TextMarshaler` / `encoding.TextUnmarshaler` interfaces
on `SubnetID` according to NeoFS API V2 protocol.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api-go that referenced this issue Nov 18, 2021
[nspcc-dev#356] netmap: Implement the functionality of working with s…
80baa75 
…ubnets

NeoFS storage node can participate in a subnet group (at least one).
According to NeoFS API V2 protocol, subnets are entered and exited through
the attributes of the node. We should provide functionality for conveniently
setting and reading attributes based on the needs of the network.

Define `NodeSubnetInfo` type which groups information about the subnet
reflected in `NodeInfo`. Implement `WriteSubnetInfo` function which writes
`SubnetInfo` data to `NodeInfo`. It will be used to prepare a request for
registration on the NeoFS network. Implement `IterateSubnets` function which
allows to iterate over all subnets of the node. Moreover, it allows you to
remove a subnet from the `NodeInfo` right during iterative traversal.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api-go that referenced this issue Nov 18, 2021
[nspcc-dev#356] netmap: Implement the functionality of working with s…
c046801 
…ubnets

NeoFS storage node can participate in a subnet group (at least one).
According to NeoFS API V2 protocol, subnets are entered and exited through
the attributes of the node. We should provide functionality for conveniently
setting and reading attributes based on the needs of the network.

Define `NodeSubnetInfo` type which groups information about the subnet
reflected in `NodeInfo`. Implement `WriteSubnetInfo` function which writes
`SubnetInfo` data to `NodeInfo`. It will be used to prepare a request for
registration on the NeoFS network. Implement `IterateSubnets` function which
allows to iterate over all subnets of the node. Moreover, it allows you to
remove a subnet from the `NodeInfo` right during iterative traversal.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api-go that referenced this issue Nov 18, 2021
[nspcc-dev#356] netmap: Return missing subnets error from `IterateSub…
a43170d 
…nets`

Each NeoFS storage node should be present in at least one subnet.

Make `netmap.IterateSubnets` function to return an error if the node by the
end of the loop does not belong to any subnet.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api-go that referenced this issue Nov 19, 2021
[nspcc-dev#356] netmap: Fix potential double-processing of zero subnet
1fe1e2e 
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api-go that referenced this issue Nov 22, 2021
[nspcc-dev#356] refs: Handle uint32 overflow in SubnetID text format
5f44eed 
Clarify the bit size limit in `SubnetID.UnmarshalText` method. Cover
overflow case in unit test.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api-go that referenced this issue Nov 22, 2021
[nspcc-dev#356] refs: Test text marshaling of nil SubnetID
5684a88 
Add `(*refs.SubnetID)(nil).MarshalText()` unit test.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api-go that referenced this issue Nov 22, 2021
[nspcc-dev#356] netmap: Document IterateSubnets behavior with dupli…
0483dc0 
…cate keys

Node attributes must be key-unique. In current implementation
`IterateSubnets` doesn't monitor the uniqueness of keys.

Declare undefined behavior of `IterateSubnets` for non-unique attribute
keys.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api-go that referenced this issue Nov 22, 2021
[nspcc-dev#356] netmap: Increase test coverage of IterateSubnets
76dcd36 
Add both `False` and `True` subnet attributes.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api-go that referenced this issue Nov 22, 2021
[nspcc-dev#356] netmap: Simplify zero subnet processing in `IterateSu…
991e756 
…bnets`

For now we don't need to distinguish cases of missing zero subnet's
attribute and the one with `True` value.

Remove local enum `zeroStatus` of `IterateSubnets` since we need to
distinguish between two statuses and use `bool` variable for this.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api-go that referenced this issue Nov 22, 2021
[nspcc-dev#356] netmap: Simplify zero subnet processing in `IterateSu…
75877eb 
…bnets`

For now we don't need to distinguish cases of missing zero subnet's
attribute and the one with `True` value.

Remove local enum `zeroStatus` of `IterateSubnets` since we need to
distinguish between two statuses and use `bool` variable for this.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api-go that referenced this issue Nov 23, 2021
[nspcc-dev#356] netmap: Simplify zero subnet processing in `IterateSu…
8a788c1 
…bnets`

For now we don't need to distinguish cases of missing zero subnet's
attribute and the one with `True` value.

Remove local enum `zeroStatus` of `IterateSubnets` since we need to
distinguish between two statuses and use `bool` variable for this.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api-go that referenced this issue Nov 23, 2021
[nspcc-dev#356] netmap: Improve docs and slightly optimize the code
52a416b 
API changes:
  * Rename `Enters` method of the `NodeSubnetInfo` to `Enabled`.
  * Declare undefined behavior of `WriteSubnetInfo` with non-unique
  attributes.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api-go that referenced this issue Nov 23, 2021
[nspcc-dev#356] refs: Implement Unmarshal method on SubnetID
e3c5539 
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api-go that referenced this issue Nov 23, 2021
[nspcc-dev#356] netmap: Fix post-loop handling of zero subnet in Iter…
f6e3cf4 
…ateSubnets

Return any error other than `ErrRemoveSubnet` from `IterateSubnets`
during post-loop processing of zero subnet.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Nov 24, 2021
@cthulhu-rider
[#356] refs: Add functions to work with zero subnet
f0af5ce 
Add helper functions which provide ease of use with subnet zero IDs.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Nov 24, 2021
@cthulhu-rider
[#356] refs: Implement text encoding of SubnetID
0e6e0e4 
Implement `encoding.TextMarshaler` / `encoding.TextUnmarshaler` interfaces
on `SubnetID` according to NeoFS API V2 protocol.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Nov 24, 2021
@cthulhu-rider
[#356] netmap: Implement the functionality of working with subnets
348f949 
NeoFS storage node can participate in a subnet group (at least one).
According to NeoFS API V2 protocol, subnets are entered and exited through
the attributes of the node. We should provide functionality for conveniently
setting and reading attributes based on the needs of the network.

Define `NodeSubnetInfo` type which groups information about the subnet
reflected in `NodeInfo`. Implement `WriteSubnetInfo` function which writes
`SubnetInfo` data to `NodeInfo`. It will be used to prepare a request for
registration on the NeoFS network. Implement `IterateSubnets` function which
allows to iterate over all subnets of the node. Moreover, it allows you to
remove a subnet from the `NodeInfo` right during iterative traversal.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Nov 24, 2021
@cthulhu-rider
[#356] netmap: Return missing subnets error from IterateSubnets
051b103 
Each NeoFS storage node should be present in at least one subnet.

Make `netmap.IterateSubnets` function to return an error if the node by the
end of the loop does not belong to any subnet.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Nov 24, 2021
@cthulhu-rider
[#356] netmap: Fix potential double-processing of zero subnet
4560e44 
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Nov 24, 2021
@cthulhu-rider
[#356] refs: Handle uint32 overflow in SubnetID text format
dc29286 
Clarify the bit size limit in `SubnetID.UnmarshalText` method. Cover
overflow case in unit test.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Nov 24, 2021
@cthulhu-rider
[#356] refs: Test text marshaling of nil SubnetID
5d99e69 
Add `(*refs.SubnetID)(nil).MarshalText()` unit test.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Nov 24, 2021
@cthulhu-rider
[#356] netmap: Document IterateSubnets behavior with duplicate keys
dfb780a 
Node attributes must be key-unique. In current implementation
`IterateSubnets` doesn't monitor the uniqueness of keys.

Declare undefined behavior of `IterateSubnets` for non-unique attribute
keys.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Nov 24, 2021
@cthulhu-rider
[#356] netmap: Increase test coverage of IterateSubnets
896cee4 
Add both `False` and `True` subnet attributes.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Nov 24, 2021
@cthulhu-rider
[#356] netmap: Simplify zero subnet processing in IterateSubnets
abc494b 
For now we don't need to distinguish cases of missing zero subnet's
attribute and the one with `True` value.

Remove local enum `zeroStatus` of `IterateSubnets` since we need to
distinguish between two statuses and use `bool` variable for this.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Nov 24, 2021
@cthulhu-rider
[#356] netmap: Improve docs and slightly optimize the code
50ab22c 
API changes:
  * Rename `Enters` method of the `NodeSubnetInfo` to `Enabled`.
  * Declare undefined behavior of `WriteSubnetInfo` with non-unique
  attributes.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Nov 24, 2021
@cthulhu-rider
[#356] refs: Implement Unmarshal method on SubnetID
5ce4b22 
Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider pushed a commit that referenced this issue Nov 24, 2021
@cthulhu-rider
[#356] netmap: Fix post-loop handling of zero subnet in IterateSubnets
d93828f 
Return any error other than `ErrRemoveSubnet` from `IterateSubnets`
during post-loop processing of zero subnet.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cthulhu-rider cthulhu-rider

Labels
enhancement Improving existing functionality
Projects
None yet
Milestone
v2.11.0
Development

Successfully merging a pull request may close this issue.

Support node attributes related to subnets cthulhu-rider/neofs-api-go
2 participants
@alexvanin @cthulhu-rider