Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support changes in signature schemes #380

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

cthulhu-rider
Copy link
Contributor

Support new SignatureRFC6979 message. Make refs.ECDSA_SHA512 to be
default scheme.

Signed-off-by: Leonard Lyubich leonard@nspcc.ru

cthulhu-rider pushed a commit to cthulhu-rider/neofs-api-go that referenced this pull request Mar 2, 2022
Support new `SignatureRFC6979` message. Make `refs.ECDSA_SHA512` to be
default scheme.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #380 (69c0d91) into master (f4fd28e) will increase coverage by 0.06%.
The diff coverage is 96.42%.

❗ Current head 69c0d91 differs from pull request most recent head 0aca94c. Consider uploading reports for the commit 0aca94c to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #380      +/-   ##
==========================================
+ Coverage   62.02%   62.09%   +0.06%     
==========================================
  Files          71       71              
  Lines       10268    10285      +17     
==========================================
+ Hits         6369     6386      +17     
  Misses       2945     2945              
  Partials      954      954              
Impacted Files Coverage Δ
refs/types.go 53.84% <0.00%> (ø)
container/convert.go 75.64% <100.00%> (+0.40%) ⬆️
container/types.go 42.81% <100.00%> (+0.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4fd28e...0aca94c. Read the comment docs.

@cthulhu-rider cthulhu-rider marked this pull request as draft March 2, 2022 10:24
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api-go that referenced this pull request Mar 2, 2022
Support new `SignatureRFC6979` message. Make `refs.ECDSA_SHA512` to be
default scheme.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
refs/types.go Outdated Show resolved Hide resolved
container/types.go Show resolved Hide resolved
cthulhu-rider pushed a commit to cthulhu-rider/neofs-api-go that referenced this pull request Mar 2, 2022
Support new `SignatureRFC6979` message. Make `refs.ECDSA_SHA512` to be
default scheme.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
Support new `SignatureRFC6979` message. Make `refs.ECDSA_SHA512` to be
default scheme.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
@cthulhu-rider cthulhu-rider marked this pull request as ready for review March 2, 2022 12:22
@alexvanin alexvanin merged commit d065453 into nspcc-dev:master Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants