Drop deploy configs #373
Merged
Drop deploy configs #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roman Khimov <roman@nspcc.ru>
Proxy doesn't need them and it doesn't have any deploy parameters. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Signed-off-by: Roman Khimov <roman@nspcc.ru>
Make them somewhat closer in style to RPC bindings. Signed-off-by: Roman Khimov <roman@nspcc.ru>
They're still there to override/keep compatibility, but they're not mandatory now. Closes #325. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Many contracts no longer have any deploy flags and while we've kept them for update during transition this is no longer needed, there is no non-notary mode. Make them completely parameterless. Signed-off-by: Roman Khimov <roman@nspcc.ru>
They're no longer needed. Signed-off-by: Roman Khimov <roman@nspcc.ru>
There is a nice well-known default. Signed-off-by: Roman Khimov <roman@nspcc.ru>
These still have parameters, but we can forget about the notary flag. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Signed-off-by: Roman Khimov <roman@nspcc.ru>
There are legends that once upon a time this parameter was used for IR keys in notaryless environments. Maybe. Who cares now though? Signed-off-by: Roman Khimov <roman@nspcc.ru>
Signed-off-by: Roman Khimov <roman@nspcc.ru>
We have a relatively stable set of configs now and this is just not needed, updates can and should work with an empty config. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Don't try interpreting data when there is no need to. Signed-off-by: Roman Khimov <roman@nspcc.ru>
41e483f was a bit more correct, we can't use std.Atoi since it's intended for C#-compatible integers which means they will be interpreted as integers for input and output (including signedness) and the resulting byte set can differ from the input one leading to failed calls. Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
requested review from
carpawell and
cthulhu-rider
as code owners
cthulhu-rider
approved these changes
Nov 28, 2023
carpawell
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#370 replacement, sorry (
-fand-dare pretty close on the keyboard).