Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get contract hashes from NNS during setup #325

Closed
roman-khimov opened this issue Feb 14, 2023 · 2 comments
Closed

Get contract hashes from NNS during setup #325

roman-khimov opened this issue Feb 14, 2023 · 2 comments
Labels
config Configuration format update or breaking change enhancement Improving existing functionality
Milestone

Comments

@roman-khimov
Copy link
Member

We have a number of contracts and they use each other for various purposes, so many of them have _deploy parameters to specify hashes of other contracts. These parameters are not very useful and making deployment/upgrades more complicated then they need to be since we always have NNS in sidechain and it always has proper hashes of the target contracts.

@roman-khimov roman-khimov added enhancement Improving existing functionality refactor config Configuration format update or breaking change labels Feb 14, 2023
@cthulhu-rider
Copy link
Contributor

I'm a bit confused of next deployment parameters:

Will there be a conflict during deployment, or it is assumed that the hashes are known in advance (in the current topic - registered in the NNS)?

@roman-khimov roman-khimov added this to the v0.18.0 milestone Mar 28, 2023
@roman-khimov
Copy link
Member Author

The first one is only used during cleanup and can be reworked to not do so, #327.

@roman-khimov roman-khimov modified the milestones: v0.18.0, v0.19.0 Sep 26, 2023
roman-khimov added a commit that referenced this issue Nov 23, 2023
They're still there to override/keep compatibility, but they're not mandatory
now. Closes #325.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov added a commit that referenced this issue Nov 24, 2023
They're still there to override/keep compatibility, but they're not mandatory
now. Closes #325.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov added a commit that referenced this issue Nov 24, 2023
They're still there to override/keep compatibility, but they're not mandatory
now. Closes #325.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov added a commit that referenced this issue Nov 27, 2023
They're still there to override/keep compatibility, but they're not mandatory
now. Closes #325.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov added a commit that referenced this issue Nov 27, 2023
They're still there to override/keep compatibility, but they're not mandatory
now. Closes #325.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov added a commit that referenced this issue Nov 27, 2023
They're still there to override/keep compatibility, but they're not mandatory
now. Closes #325.

Signed-off-by: Roman Khimov <roman@nspcc.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config Configuration format update or breaking change enhancement Improving existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants