-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get contract hashes from NNS during setup #325
Labels
Milestone
Comments
roman-khimov
added
enhancement
Improving existing functionality
refactor
config
Configuration format update or breaking change
labels
Feb 14, 2023
I'm a bit confused of next deployment parameters:
Will there be a conflict during deployment, or it is assumed that the hashes are known in advance (in the current topic - registered in the NNS)? |
The first one is only used during |
roman-khimov
added a commit
that referenced
this issue
Nov 23, 2023
They're still there to override/keep compatibility, but they're not mandatory now. Closes #325. Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
added a commit
that referenced
this issue
Nov 24, 2023
They're still there to override/keep compatibility, but they're not mandatory now. Closes #325. Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
added a commit
that referenced
this issue
Nov 24, 2023
They're still there to override/keep compatibility, but they're not mandatory now. Closes #325. Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
added a commit
that referenced
this issue
Nov 27, 2023
They're still there to override/keep compatibility, but they're not mandatory now. Closes #325. Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
added a commit
that referenced
this issue
Nov 27, 2023
They're still there to override/keep compatibility, but they're not mandatory now. Closes #325. Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
added a commit
that referenced
this issue
Nov 27, 2023
They're still there to override/keep compatibility, but they're not mandatory now. Closes #325. Signed-off-by: Roman Khimov <roman@nspcc.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
We have a number of contracts and they use each other for various purposes, so many of them have
_deploy
parameters to specify hashes of other contracts. These parameters are not very useful and making deployment/upgrades more complicated then they need to be since we always have NNS in sidechain and it always has proper hashes of the target contracts.The text was updated successfully, but these errors were encountered: