Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock objects do not fill metabase on resync_metabase #1502

Closed
carpawell opened this issue Jun 9, 2022 · 2 comments · Fixed by #1534 or #2050
Closed

Lock objects do not fill metabase on resync_metabase #1502

carpawell opened this issue Jun 9, 2022 · 2 comments · Fixed by #1534 or #2050
Labels
bug Something isn't working neofs-storage Storage node application issues question Further information is requested U2 Seriously planned
Milestone
v0.29.0

Comments

@carpawell
Copy link
Member

carpawell commented Jun 9, 2022 •
edited
Loading

Seems like it is true. SE does not call Lock.

Needed to be verified. If true, we are losing every lock relationship on every metabase dropping.
@carpawell carpawell added bug Something isn't working question Further information is requested neofs-storage Storage node application issues labels Jun 9, 2022
@fyrchik fyrchik mentioned this issue Jun 20, 2022
Merged
aprasolova pushed a commit to aprasolova/neofs-node that referenced this issue Oct 19, 2022
@fyrchik @aprasolova
[nspcc-dev#1502] shard: Process locks on metabase refill
c721fff 
Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
@carpawell carpawell reopened this Oct 25, 2022
@carpawell
Copy link
Member Author

carpawell commented Oct 25, 2022 •
edited
Loading 

root@vedi:/home/service# neofs-cli container create -r node1:8080 -w /etc/neofs/storage/wallet.json --policy "REP 1 IN n3 SELECT 1 FROM n3 AS n3 FILTER Node EQ node3 AS n3" --await --basic-acl public-read-write
Enter password >
container ID: 2w6wuU8j1JtQaq2iLa6ALqBNr3L6JfKZcAJpLGUufj3P
awaiting...
container has been persisted on sidechain
root@vedi:/home/service# neofs-cli object put -r node3:8080 -w /etc/neofs/storage/wallet.json  --file /home/service/.profile --no-progress --cid 2w6wuU8j1JtQaq2iLa6ALqBNr3L6JfKZcAJpLGUufj3P
Enter password >
[/home/service/.profile] Object successfully stored
  OID: 82G8FeerV8GaE7raSZyiLCwbKTuwNMvz5J7qcGPRLBqM
  CID: 2w6wuU8j1JtQaq2iLa6ALqBNr3L6JfKZcAJpLGUufj3P
root@vedi:/home/service# neofs-cli object lock -r node3:8080 -w /etc/neofs/storage/wallet.json --expire-at 30 2w6wuU8j1JtQaq2iLa6ALqBNr3L6JfKZcAJpLGUufj3P 82G8FeerV8GaE7raSZyiLCwbKTuwNMvz5J7qcGPRLBqM
Enter password >
Lock object ID: CGqogCPVnyqM1xTGW627TLNMhUxoPBG2Y7MwU5SP1X6j
Objects successfully locked.
root@vedi:/home/service# neofs-cli object delete  -r node3:8080 -w /etc/neofs/storage/wallet.json  --cid 2w6wuU8j1JtQaq2iLa6ALqBNr3L6JfKZcAJpLGUufj3P --oid 82G8FeerV8GaE7raSZyiLCwbKTuwNMvz5J7qcGPRLBqM
Enter password >
rpc error: remove object via client: status: code = 2050 message = object is locked
root@vedi:/home/service# systemctl restart  neofs-storage
root@vedi:/home/service# neofs-cli object delete  -r node3:8080 -w /etc/neofs/storage/wallet.json  --cid 2w6wuU8j1JtQaq2iLa6ALqBNr3L6JfKZcAJpLGUufj3P --oid 82G8FeerV8GaE7raSZyiLCwbKTuwNMvz5J7qcGPRLBqM
Enter password >
Object removed successfully.
  ID: 8uu2Vug46ekFvWGqVqc8fZvNLfk7x9gLaPvtq1YdyZrx
  CID: 2w6wuU8j1JtQaq2iLa6ALqBNr3L6JfKZcAJpLGUufj3P
root@az:/home/service# neofs-cli object get -r node1:8080 -w /etc/neofs/storage/wallet.json --cid 2w6wuU8j1JtQaq2iLa6ALqBNr3L6JfKZcAJpLGUufj3P --oid 82G8FeerV8GaE7raSZyiLCwbKTuwNMvz5J7qcGPRLBqM  --file /tmp/get_object.sample --no-progress
Enter password >
rpc error: read object header: status: code = 2052 message = object already removed
root@az:/home/service# neofs-cli object get -r node2:8080 -w /etc/neofs/storage/wallet.json --cid 2w6wuU8j1JtQaq2iLa6ALqBNr3L6JfKZcAJpLGUufj3P --oid 82G8FeerV8GaE7raSZyiLCwbKTuwNMvz5J7qcGPRLBqM  --file /tmp/get_object.sample --no-progress
Enter password >
rpc error: read object header: status: code = 2052 message = object already removed
root@az:/home/service#
root@az:/home/service# neofs-cli object get -r node3:8080 -w /etc/neofs/storage/wallet.json --cid 2w6wuU8j1JtQaq2iLa6ALqBNr3L6JfKZcAJpLGUufj3P --oid 82G8FeerV8GaE7raSZyiLCwbKTuwNMvz5J7qcGPRLBqM  --file /tmp/get_object.sample --no-progress
Enter password >
rpc error: read object header: status: code = 2052 message = object already removed
root@az:/home/service# neofs-cli object get -r node4:8080 -w /etc/neofs/storage/wallet.json --cid 2w6wuU8j1JtQaq2iLa6ALqBNr3L6JfKZcAJpLGUufj3P --oid 82G8FeerV8GaE7raSZyiLCwbKTuwNMvz5J7qcGPRLBqM  --file /tmp/get_object.sample --no-progress
Enter password >
rpc error: read object header: status: code = 2052 message = object already removed
root@az:/home/service#

Possible reason: #1972 (comment).

@carpawell carpawell self-assigned this Nov 11, 2022
@carpawell carpawell mentioned this issue Nov 12, 2022
Merged
@carpawell carpawell removed their assignment Nov 30, 2022
@roman-khimov roman-khimov mentioned this issue Apr 22, 2023
Closed
vvarg229 added a commit to vvarg229/neofs-testcases that referenced this issue Aug 21, 2023
@vvarg229
object: Add restart nodes lock object tests nspcc-dev#550
7ab6a15 
The test_the_object_lock_should_be_kept_after_restarting_the_nodes
test added.
This test verifies the issue
nspcc-dev/neofs-node#1502

Signed-off-by: Oleg Kulachenko <oleg@nspcc.ru>
vvarg229 added a commit to vvarg229/neofs-testcases that referenced this issue Aug 21, 2023
@vvarg229
object: Add restart nodes lock object tests nspcc-dev#550
c1a175b 
The test_the_object_lock_should_be_kept_after_restarting_the_nodes
test added.
This test verifies the issue
nspcc-dev/neofs-node#1502

Signed-off-by: Oleg Kulachenko <oleg@nspcc.ru>
@roman-khimov roman-khimov mentioned this issue Aug 22, 2023
Merged
vvarg229 added a commit to vvarg229/neofs-testcases that referenced this issue Aug 30, 2023
@vvarg229
object: Add restart nodes lock object tests nspcc-dev#550
914c3d0 
The test_the_object_lock_should_be_kept_after_restarting_the_nodes
test added.
This test verifies the issue
nspcc-dev/neofs-node#1502

Signed-off-by: Oleg Kulachenko <oleg@nspcc.ru>
vvarg229 added a commit to vvarg229/neofs-testcases that referenced this issue Sep 7, 2023
@vvarg229
object: Add restart nodes lock object tests nspcc-dev#556
5c18773 
The test_the_object_lock_should_be_kept_after_restarting_the_nodes
test added.
This test verifies the issue
nspcc-dev/neofs-node#1502

Signed-off-by: Oleg Kulachenko <oleg@nspcc.ru>
vvarg229 added a commit to vvarg229/neofs-testcases that referenced this issue Sep 7, 2023
@vvarg229
object: Add restart nodes lock object tests nspcc-dev#556
a7e75dd 
The test_the_object_lock_should_be_kept_after_restarting_the_nodes
test added.
This test verifies the issue
nspcc-dev/neofs-node#1502

Signed-off-by: Oleg Kulachenko <oleg@nspcc.ru>
vvarg229 added a commit to vvarg229/neofs-testcases that referenced this issue Sep 7, 2023
@vvarg229
object: Add restart nodes lock object tests nspcc-dev#556
ab4a30c 
The test_the_object_lock_should_be_kept_after_restarting_the_nodes
test added.
This test verifies the issue
nspcc-dev/neofs-node#1502

Signed-off-by: Oleg Kulachenko <oleg@nspcc.ru>
vvarg229 added a commit to vvarg229/neofs-testcases that referenced this issue Sep 8, 2023
@vvarg229
object: Add restart nodes lock object tests nspcc-dev#556
97a6e19 
The test_the_object_lock_should_be_kept_after_restarting_the_nodes
test added.
This test verifies the issue
nspcc-dev/neofs-node#1502

Signed-off-by: Oleg Kulachenko <oleg@nspcc.ru>
vvarg229 added a commit to vvarg229/neofs-testcases that referenced this issue Sep 12, 2023
@vvarg229
object: Add restart nodes lock object tests nspcc-dev#556
729bcb5 
The test_the_object_lock_should_be_kept_after_restarting_the_nodes
test added.
This test verifies the issue
nspcc-dev/neofs-node#1502

Signed-off-by: Oleg Kulachenko <oleg@nspcc.ru>
vvarg229 added a commit to vvarg229/neofs-testcases that referenced this issue Sep 14, 2023
@vvarg229
object: Add restart nodes lock object tests nspcc-dev#556
f998bea 
The test_the_object_lock_should_be_kept_after_restarting_the_nodes
test added.
This test verifies the issue
nspcc-dev/neofs-node#1502

Signed-off-by: Oleg Kulachenko <oleg@nspcc.ru>
vvarg229 added a commit to vvarg229/neofs-testcases that referenced this issue Sep 25, 2023
@vvarg229
object: Add restart nodes lock object tests nspcc-dev#556
0310179 
The test_the_object_lock_should_be_kept_after_metabase_deletion
test added.
This test verifies the issue
nspcc-dev/neofs-node#1502

Signed-off-by: Oleg Kulachenko <oleg@nspcc.ru>
vvarg229 added a commit to vvarg229/neofs-testcases that referenced this issue Sep 25, 2023
@vvarg229
object: Add restart nodes lock object tests nspcc-dev#556
8d97847 
The test_the_object_lock_should_be_kept_after_metabase_deletion
test added.
This test verifies the issue
nspcc-dev/neofs-node#1502

Signed-off-by: Oleg Kulachenko <oleg@nspcc.ru>
vvarg229 added a commit to vvarg229/neofs-testcases that referenced this issue Sep 28, 2023
@vvarg229
object: Add restart nodes lock object tests nspcc-dev#556
89a0712 
The test_the_object_lock_should_be_kept_after_metabase_deletion
test added.
This test verifies the issue
nspcc-dev/neofs-node#1502

Signed-off-by: Oleg Kulachenko <oleg@nspcc.ru>
@roman-khimov
Copy link
Member

Not an issue now and this one is about a 0.29.0 fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working neofs-storage Storage node application issues question Further information is requested U2 Seriously planned
Projects
None yet
Milestone
v0.29.0
5 participants
@fyrchik @roman-khimov @carpawell @alexchetaev @cthulhu-rider