Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add histograms for request metrics #2351

Closed
roman-khimov opened this issue May 19, 2023 · 0 comments · Fixed by #2473
Closed

Add histograms for request metrics #2351

roman-khimov opened this issue May 19, 2023 · 0 comments · Fixed by #2473
Assignees
@carpawell
Labels
enhancement Improving existing functionality good first issue Good for newcomers neofs-ir Inner Ring node application issues neofs-storage Storage node application issues
Milestone
v0.38.0

Comments

@roman-khimov
Copy link
Member

Is your feature request related to a problem? Please describe.

I'm always frustrated when I'm looking at counters for requests, histograms are much more useful and don't add a lot of cost.

Describe the solution you'd like

Use prometheus.Histogram instead of counters for request metrics.

Describe alternatives you've considered

Leaving things as is. Meh.

Additional context

#2344. nspcc-dev/neo-go#2784.
@roman-khimov roman-khimov added enhancement Improving existing functionality good first issue Good for newcomers neofs-ir Inner Ring node application issues neofs-storage Storage node application issues labels May 19, 2023
@roman-khimov roman-khimov added this to the v0.38.0 milestone May 19, 2023
@carpawell carpawell self-assigned this Jul 24, 2023
carpawell added a commit to carpawell/neofs-node that referenced this issue Aug 6, 2023
@carpawell
metrics: Add histograms for duration metrics
a8e2a15 
Deprecate `prometheus.Counter` analogs. Closes nspcc-dev#2351.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell carpawell mentioned this issue Aug 6, 2023
Merged
carpawell added a commit to carpawell/neofs-node that referenced this issue Aug 7, 2023
@carpawell
metrics: Add histograms for duration metrics
74dcb20 
Deprecate `prometheus.Counter` analogs. Closes nspcc-dev#2351.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit to carpawell/neofs-node that referenced this issue Aug 9, 2023
@carpawell
metrics: Add histograms for duration metrics
e4fd754 
Deprecate `prometheus.Counter` analogs. Closes nspcc-dev#2351.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit to carpawell/neofs-node that referenced this issue Aug 9, 2023
@carpawell
metrics: Add histograms for duration metrics
f39dd59 
Deprecate `prometheus.Counter` analogs. Closes nspcc-dev#2351.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
carpawell added a commit to carpawell/neofs-node that referenced this issue Aug 9, 2023
@carpawell
metrics: Add histograms for duration metrics
a949ece 
Deprecate `prometheus.Counter` analogs. Closes nspcc-dev#2351.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
roman-khimov added a commit that referenced this issue Aug 9, 2023
@roman-khimov
feat/Add histograms for duration metrics (#2473)
f38069e 
Deprecate `prometheus.Counter` analogs. Closes #2351.
@roman-khimov roman-khimov mentioned this issue Apr 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carpawell carpawell

Labels
enhancement Improving existing functionality good first issue Good for newcomers neofs-ir Inner Ring node application issues neofs-storage Storage node application issues
Projects
None yet
Milestone
v0.38.0
Development

Successfully merging a pull request may close this issue.

feat/Add histograms for duration metrics carpawell/neofs-node
2 participants
@roman-khimov @carpawell