Feat/Add version metrics #2344
Merged
Feat/Add version metrics #2344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2344 +/- ##
==========================================
- Coverage 29.88% 29.88% -0.01%
==========================================
Files 398 398
Lines 29806 29806
==========================================
- Hits 8909 8907 -2
- Misses 20180 20182 +2
Partials 717 717
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
notimetoname
force-pushed
the
feat/add-version-metrics
branch
from
270c5e9
to
99605d0
Compare
cthulhu-rider
approved these changes
May 19, 2023
- use a separate `neofs_ir` namespace for IR apps instead of `neofs_node`; - move `epoch` metrics to a `state` subsystem instead of `object`; - SN's epoch metrics do not have "inner-ring" help message now. The old ones are deprecated and will be removed when the next minor release comes out. Signed-off-by: Pavel Karpy <carpawell@morphbits.io>
Signed-off-by: Pavel Karpy <carpawell@morphbits.io>
Forgotten but necessary renaming. Signed-off-by: Pavel Karpy <carpawell@morphbits.io>
notimetoname
force-pushed
the
feat/add-version-metrics
branch
from
99605d0
to
045a284
Compare
roman-khimov
approved these changes
May 19, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2326. Gonna look smth like that:
@roman-khimov, @cthulhu-rider, @532910, @aprasolova, @anyone_looking_at_metrics, please, look at the first commit. Something was certainly wrong, pay attention to it and make me know if some SW depends on it and we are not able to make such changes OR such changes must be synced before the merge.