-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I'm able to find the object that is marked for deletion #2376
Comments
|
Next available for now (3)? |
We have a falling system test test_object2_can_be_get_by_attr https://github.com/nspcc-dev/neofs-testcases/blob/master/pytest_tests/testsuites/services/http_gate/test_http_headers.py#L110 We delete an object and expect an "object already removed" error to be returned when we try to get it after the deletion. Right now it works so that we get "404 not found". Is this expected behavior correct? allure report: |
That's nspcc-dev/neofs-http-gw@e6e7941 and that's correct, the object can no longer be found. Previously it was "Bad Request" returned from the HTTP gate and that wasn't correct, the request is perfectly fine here. |
Can be checked for the mainnet |
Also includes a test for removed but locked objects. Refs nspcc-dev#2376. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Also includes a test for removed but locked objects. Refs nspcc-dev#2376. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
I have been looking at that bug for a while but have not found any problems. I tested mentioned contianers, look at the code but seems like it is impossible (or I need to look at this in some removal process or at the script). Added a separate code in #2526. I guess, script may do some things fast while TS objects have not been replicated yet. |
Refs nspcc-dev#2376. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Also includes a test for removed but locked objects. Refs nspcc-dev#2376. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Refs nspcc-dev#2376. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Refs nspcc-dev#2376. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
The way the script worked at the time of writing is:
IIRC the problem happened when someone tried to run the script several times in a row before objects are really deleted. So it's certainly not some ms-range problem. |
Also includes a test for removed but locked objects. Refs nspcc-dev#2376. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Also includes a test for removed but locked objects. Refs nspcc-dev#2376. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Refs nspcc-dev#2376. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Refs nspcc-dev#2376. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Also includes a test for removed but locked objects. Refs nspcc-dev#2376. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Refs nspcc-dev#2376. Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
Considering this as fixed until proven otherwise. |
In testnet, I search for an object by
FilePath
attribute in the containerApUZhHKta4pikXAtvJR2sBQ3TikKErywCCdQQKgWAgvp
. I find the object9DRzt8EBLeoueo6axHr58sYj6V4a5BLXSQ7jSwNAo1gf
. Then I try to delete it and get errorcode = 2052 message = object already removed
. I guess it happens because the object is marked for deletion.Expected Behaviour
If object is marked for deletion, it doesn't appear as a search result.
Current Behavior
It does
The text was updated successfully, but these errors were encountered: