Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to dump hashes for the custom zone #1748

Merged
merged 6 commits into from
Sep 2, 2022
Merged

Allow to dump hashes for the custom zone #1748

merged 6 commits into from
Sep 2, 2022

Conversation

fyrchik
Copy link
Contributor

@fyrchik fyrchik commented Sep 2, 2022

Also, set addresses instead of hex-hashes for custom contracts.

@alexvanin
Copy link
Contributor

Also, set addresses instead of hex-hashes for custom contracts.

So all contract related TXT records for both custom and neofs contracts store string LE encoded addresses, right?

@codecov
Copy link

codecov bot commented Sep 2, 2022 •
edited
Loading

Codecov Report

Merging #1748 (36be5dd) into master (e26e70f) will decrease coverage by 0.10%.
The diff coverage is 0.47%.

@@            Coverage Diff             @@
##           master    #1748      +/-   ##
==========================================
- Coverage   33.20%   33.09%   -0.11%     
==========================================
  Files         350      351       +1     
  Lines       23397    23473      +76     
==========================================
+ Hits         7768     7769       +1     
- Misses      14978    15053      +75     
  Partials      651      651
Impacted Files Coverage Δ
cmd/neofs-adm/internal/modules/morph/config.go 0.00% <ø> (ø)
cmd/neofs-adm/internal/modules/morph/deploy.go 7.14% <0.00%> (-0.06%) ⬇️
...md/neofs-adm/internal/modules/morph/dump_hashes.go 0.00% <0.00%> (ø)
...fs-adm/internal/modules/morph/initialize_deploy.go 0.00% <0.00%> (ø)
...neofs-adm/internal/modules/morph/initialize_nns.go 0.00% <0.00%> (ø)
cmd/neofs-adm/internal/modules/morph/root.go 49.65% <100.00%> (+0.34%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@fyrchik
Copy link
Contributor Author

fyrchik commented Sep 2, 2022

@alexvanin no, for custom we store the address only, for neofs we store the hex. In another PR we will store 2 TXT records for neofs contracts, this could need some changes in the NNS contract.

alexvanin
alexvanin previously approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@alexvanin alexvanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, didn't test.

@fyrchik
Copy link
Contributor Author

fyrchik commented Sep 2, 2022

I have tested init, deploy and dump-hashes. Today I have added 2 commits with refactoring @realloc could you test this branch for your use-case?

realloc
realloc previously approved these changes Sep 2, 2022
View reviewed changes
Copy link

@realloc realloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for simple TX

@fyrchik
[nspcc-dev#1748] neofs-adm: Move dump-hashes command to a separate …
ba11186 
…file

I have just lost 3 minutes trying to find it.

Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
@fyrchik
[nspcc-dev#1748] neofs-adm: Remove addRecord from `nnsRegisterDomai…
b194bd6 
…nScript`

Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
@fyrchik
[nspcc-dev#1748] neofs-adm: Refactor NNS price handling
3ebf034 
Make `nnsRegisterDomainScript` simpler.

Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
@fyrchik
[nspcc-dev#1748] neofs-adm: Set custom contract hashes as N3 address
a96bbbc 
Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
@fyrchik
[nspcc-dev#1748] neofs-adm: Allow to parse hashes in multiple formats
a42e2b4 
NEO NNS proposal uses addresses. We should eventually use the same,
but must stay compatible now.

Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
@fyrchik
[nspcc-dev#1748] neofs-adm: Allow to dump hashes from a custom zone
36be5dd 
Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
@fyrchik fyrchik merged commit fef4f6d into nspcc-dev:master Sep 2, 2022
@fyrchik fyrchik mentioned this pull request Sep 5, 2022
Closed
@carpawell carpawell mentioned this pull request Sep 14, 2022
Merged
aprasolova pushed a commit to aprasolova/neofs-node that referenced this pull request Oct 19, 2022
@fyrchik @aprasolova
[nspcc-dev#1748] neofs-adm: Move dump-hashes command to a separate …
c012250 
…file

I have just lost 3 minutes trying to find it.

Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this pull request Oct 19, 2022
@fyrchik @aprasolova
[nspcc-dev#1748] neofs-adm: Remove addRecord from `nnsRegisterDomai…
2f6fd43 
…nScript`

Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this pull request Oct 19, 2022
@fyrchik @aprasolova
[nspcc-dev#1748] neofs-adm: Refactor NNS price handling
b0b071f 
Make `nnsRegisterDomainScript` simpler.

Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this pull request Oct 19, 2022
@fyrchik @aprasolova
[nspcc-dev#1748] neofs-adm: Set custom contract hashes as N3 address
b11a290 
Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this pull request Oct 19, 2022
@fyrchik @aprasolova
[nspcc-dev#1748] neofs-adm: Allow to parse hashes in multiple formats
34c4c9a 
NEO NNS proposal uses addresses. We should eventually use the same,
but must stay compatible now.

Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
aprasolova pushed a commit to aprasolova/neofs-node that referenced this pull request Oct 19, 2022
@fyrchik @aprasolova
[nspcc-dev#1748] neofs-adm: Allow to dump hashes from a custom zone
d27890d 
Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
@vdomnich-yadro vdomnich-yadro mentioned this pull request Nov 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carpawell carpawell carpawell approved these changes

@realloc realloc realloc left review comments

@alexvanin alexvanin alexvanin left review comments

Assignees

@fyrchik fyrchik

Labels
enhancement Improving existing functionality neofs-adm NeoFS Adm application issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fyrchik @alexvanin @realloc @carpawell