-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support new hash format in morph nns client #2063
Support new hash format in morph nns client #2063
Conversation
Codecov Report
@@ Coverage Diff @@
## support/v0.34 #2063 +/- ##
==============================================
Coverage 30.66% 30.66%
==============================================
Files 380 380
Lines 28080 28077 -3
==============================================
Hits 8610 8610
+ Misses 18731 18728 -3
Partials 739 739
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add morph/client:
prefix to your commit message?
I have recieved a notification of a new pull request. I am starting the build of images and binaries for further testing. |
I have recieved a notification of a new pull request. I am starting the build of images and binaries for further testing. |
Thanks for approvals! @realloc I don't have permissions to merge PR by myself 😔 |
I have recieved a notification of a new pull request. I am starting the build of images and binaries for further testing. |
…lient Signed-off-by: Vladimir Domnich <v.domnich@yadro.com>
I have recieved a notification of a new pull request. I am starting the build of images and binaries for further testing. |
In #1748 we've introduced a small inconsistency in NNS hash parsing:
This PR updates implementation of nnsResolve so that it is consistent with parseNNSResolveResult.
Per discussion with @fyrchik for now we just add missing logic to nnsResolve. In the future we will refactor implementation so that the logic is implemented in a single place.