node: Serve NetmapService.NetmapSnapshot RPC
#1793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1793 +/- ##
==========================================
+ Coverage 33.41% 33.66% +0.24%
==========================================
Files 352 352
Lines 23962 23737 -225
==========================================
- Hits 8008 7991 -17
+ Misses 15287 15081 -206
+ Partials 667 665 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cthulhu-rider
pushed a commit
to cthulhu-rider/neofs-node
that referenced
this pull request
Sep 22, 2022
There is no more need to serve the same request on Control API. Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider
force-pushed
the
feature/netmap-snapshot
branch
from
da1067a
to
3cc784a
Compare
cthulhu-rider
pushed a commit
to cthulhu-rider/neofs-node
that referenced
this pull request
Sep 22, 2022
There is no more need to serve the same request on Control API. Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider
force-pushed
the
feature/netmap-snapshot
branch
from
3cc784a
to
9973911
Compare
cthulhu-rider
pushed a commit
to cthulhu-rider/neofs-node
that referenced
this pull request
Sep 22, 2022
There is no more need to serve the same request on Control API. Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider
force-pushed
the
feature/netmap-snapshot
branch
from
9973911
to
0f8b975
Compare
acid-ant
previously approved these changes
Sep 22, 2022
fyrchik
previously approved these changes
Sep 22, 2022
carpawell
reviewed
Sep 22, 2022
cmd/neofs-node/config.go
Outdated
| netMap atomicstd.Value // type netmap.NetMap | ||
| } | ||
|
|
||
| func (c *cfg) ProcessCurrentNetMap(f func(netmap.NetMap)) { |
There was a problem hiding this comment.
The need is to perform exact single action. We could implement it as a getter, doesn' matter.
There was a problem hiding this comment.
I also think CurrentNetmap() netmap.NetMap is simpler to read and use.
There was a problem hiding this comment.
Finally I've decided to leave netmap service package a dummy message constructor. All the business logic is implemented on application side. 0e7bc5d
There is no more need to serve the same request on Control API. Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
cthulhu-rider
dismissed stale reviews from fyrchik and acid-ant
via
932c24d
cthulhu-rider
force-pushed
the
feature/netmap-snapshot
branch
from
0f8b975
to
932c24d
Compare
…map reader Replace `ProcessCurrentNetMap` method of `NodeState` interface with `ReadCurrentNetMap` one with two changes: * Replace network map type from NeoFS SDK package with the protocol-generated message. This replaces all the business logic to the application layer. * Support error return. This allows to cover problem node states. Return an error from `NodeState.ReadCurrentNetMap` method implemeted through `atomic.Value` if `Store` method has not been called yet. Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
fyrchik
approved these changes
Sep 26, 2022
acid-ant
approved these changes
Sep 26, 2022
aprasolova
pushed a commit
to aprasolova/neofs-node
that referenced
this pull request
Oct 19, 2022
There is no more need to serve the same request on Control API. Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
aprasolova
pushed a commit
to aprasolova/neofs-node
that referenced
this pull request
Oct 19, 2022
…map reader Replace `ProcessCurrentNetMap` method of `NodeState` interface with `ReadCurrentNetMap` one with two changes: * Replace network map type from NeoFS SDK package with the protocol-generated message. This replaces all the business logic to the application layer. * Support error return. This allows to cover problem node states. Return an error from `NodeState.ReadCurrentNetMap` method implemeted through `atomic.Value` if `Store` method has not been called yet. Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no more need to serve the same request on Control API.
NetmapService.NetmapSnapshotRPC neofs-sdk-go#337