Allow to replicate object to other nodes in control.EvacuateShard
#1800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1800 +/- ##
==========================================
+ Coverage 33.41% 33.45% +0.04%
==========================================
Files 352 352
Lines 23962 23969 +7
==========================================
+ Hits 8008 8020 +12
+ Misses 15287 15283 -4
+ Partials 667 666 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cthulhu-rider
previously approved these changes
Sep 20, 2022
carpawell
reviewed
Sep 20, 2022
carpawell
reviewed
Sep 20, 2022
| } | ||
| } | ||
|
|
||
| var res replicatorResult |
There was a problem hiding this comment.
what if nodes is empty after the current node exclusion?
There was a problem hiding this comment.
The res.count == 0 after HandleTask and we will return an error.
There was a problem hiding this comment.
HandleTask has some debug logging even with an empty task so i meant it could be cached earlier, but ok
Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
…vacuateShard RPC Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
… parameters Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
carpawell
approved these changes
Sep 23, 2022
cthulhu-rider
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #1105