pilorama: merge in-queue batches #2231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## support/v0.35 #2231 +/- ##
==============================================
Coverage 30.87% 30.88%
==============================================
Files 383 383
Lines 28389 28393 +4
==============================================
+ Hits 8766 8770 +4
Misses 18876 18876
Partials 747 747
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
acid-ant
previously approved these changes
Feb 2, 2023
carpawell
reviewed
Feb 2, 2023
To achieve high performance we must choose proper values for both batch size and delay. For user operations we want to set low delay. However it would prevent tree synchronization operations to form big enough batches. For these operations, batching gives the most benefit not only in terms of on-CPU execution cost, but also by speeding up transaction persist (`fsync`). In this commit we try merging batches that are already _triggered_, but not yet _started to execute_. This way we can still query batches for execution after the provided delay while also allowing multiple formed batches to execute faster. Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
acid-ant
approved these changes
Feb 2, 2023
What are the numbers in ops/s? |
|
I don't have exact numbers saved (but @anatoly-bogatyrev can help here). |
carpawell
approved these changes
Feb 2, 2023
|
Wrong PR number in commit msg 😬. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To achieve high performance we must choose proper values for both batch size and delay. For user operations we want to set low delay. However it would prevent tree synchronization operations to form big enough batches. For these operations, batching gives the most benefit not only in terms of on-CPU execution cost, but also by speeding up transaction persist (
fsync).In this commit we try merging batches that are already triggered, but not yet started to execute. This way we can still query batches for execution after the provided delay while also allowing multiple formed batches to execute faster.
Hardware performance tests show ~10x improvement for small objects put in one bucket.
Signed-off-by: Evgenii Stratonikov e.stratonikov@yadro.com