Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Do not lose small objects on WC errors #2336

Merged

Conversation

notimetoname
Copy link
Contributor

No description provided.

@notimetoname notimetoname added bug Something isn't working neofs-storage Storage node application issues labels May 11, 2023
@notimetoname notimetoname self-assigned this May 11, 2023
@roman-khimov roman-khimov added this to the v0.37.0 milestone May 11, 2023
@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #2336 (cb80941) into master (0e3fe05) will not change coverage.
The diff coverage is 100.00%.

❗ Current head cb80941 differs from pull request most recent head b0acada. Consider uploading reports for the commit b0acada to get more accurate results

@@           Coverage Diff           @@
##           master    #2336   +/-   ##
=======================================
  Coverage   29.87%   29.87%           
=======================================
  Files         398      398           
  Lines       29822    29822           
=======================================
  Hits         8909     8909           
  Misses      20199    20199           
  Partials      714      714           
Impacted Files Coverage Δ
pkg/local_object_storage/writecache/put.go 71.42% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cthulhu-rider
Copy link
Contributor

rdy, conflicts

Signed-off-by: Pavel Karpy <carpawell@morphbits.io>
@notimetoname notimetoname force-pushed the fix/WC-small-objects-dropping branch from d2e90f8 to b0acada Compare May 12, 2023 11:39
@cthulhu-rider cthulhu-rider merged commit a8a55bc into nspcc-dev:master May 12, 2023
@notimetoname notimetoname deleted the fix/WC-small-objects-dropping branch May 12, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working neofs-storage Storage node application issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants