object: Purge notification functionality #2750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cthulhu-rider
commented
Feb 26, 2024
cthulhu-rider
commented
- based on and blocked by Drop __NEOFS__TICK things neofs-api#279
cthulhu-rider
force-pushed
the
object-purge-notify
branch
from
982b2c9
to
231c478
Compare
cthulhu-rider
added a commit
to nspcc-dev/neofs-dev-env
that referenced
this pull request
Feb 26, 2024
NeoFS storage nodes do not support them since nspcc-dev/neofs-node#2750. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2750 +/- ##
==========================================
+ Coverage 28.86% 28.92% +0.06%
==========================================
Files 415 414 -1
Lines 32485 32345 -140
==========================================
- Hits 9376 9356 -20
+ Misses 22265 22145 -120
Partials 844 844 ☔ View full report in Codecov by Sentry. |
cthulhu-rider
force-pushed
the
object-purge-notify
branch
from
231c478
to
ecd2812
Compare
cthulhu-rider
requested review from
roman-khimov and
carpawell
as code owners
cthulhu-rider
force-pushed
the
object-purge-notify
branch
from
ecd2812
to
a08075d
Compare
roman-khimov
approved these changes
Feb 28, 2024
carpawell
approved these changes
Feb 28, 2024
There was a problem hiding this comment.
- Do we plan supporting notifications somehow in the future on the node level? @roman-khimov
- Can you, please, drop that functionality in the dev-env too?
nspcc-dev/neofs-dev-env#305. If i forgot smth, pls report there |
They were marked as deprecated in the protocol in nspcc-dev/neofs-api#279. NATS is no longer needed. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
object-purge-notify
branch
from
a08075d
to
70a6c98
Compare
|
Oh, that is great, has not seen it yet. |
roman-khimov
pushed a commit
to nspcc-dev/neofs-dev-env
that referenced
this pull request
Apr 19, 2024
NeoFS storage nodes do not support them since nspcc-dev/neofs-node#2750. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.