Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process epoch X-headers in object read operations #305

Merged
merged 2 commits into from
Jan 12, 2021

Conversation

cthulhu-rider
Copy link
Contributor

Relates #234.

@cthulhu-rider cthulhu-rider self-assigned this Jan 12, 2021
@cthulhu-rider cthulhu-rider added enhancement Improving existing functionality neofs-storage Storage node application issues labels Jan 12, 2021
@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #305 (d143b0f) into master (1d56e60) will increase coverage by 0.07%.
The diff coverage is 56.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #305      +/-   ##
==========================================
+ Coverage   51.46%   51.53%   +0.07%     
==========================================
  Files         128      128              
  Lines        4640     4713      +73     
==========================================
+ Hits         2388     2429      +41     
- Misses       2050     2077      +27     
- Partials      202      207       +5     
Impacted Files Coverage Δ
pkg/services/object/get/service.go 0.00% <0.00%> (ø)
pkg/services/object/get/util.go 17.91% <0.00%> (-0.28%) ⬇️
pkg/services/object/search/service.go 0.00% <0.00%> (ø)
pkg/services/object/search/util.go 32.35% <0.00%> (-0.99%) ⬇️
pkg/services/object_manager/placement/netmap.go 0.00% <0.00%> (ø)
pkg/services/object/get/exec.go 71.34% <42.85%> (-3.84%) ⬇️
pkg/services/object/search/exec.go 51.35% <42.85%> (-3.20%) ⬇️
pkg/services/object/search/container.go 71.79% <76.19%> (+0.96%) ⬆️
pkg/services/object/get/container.go 76.92% <85.00%> (+4.92%) ⬆️
pkg/services/object/get/prm.go 70.00% <0.00%> (+10.00%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d56e60...d143b0f. Read the comment docs.

Add GetNetMapByEpoch method. Add Epoch method.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
… in read ops

Support processing of NetmapEpoch and NetmapLookupDepth X-headers when
processing object read operations. Placement for operations
Get/Head/GetRange/GetRangeHash/Search is built for the epoch specified in
NetmapEpoch X-header (by default latest). Also the specified operations are
processed until success is achieved for network maps from the past up to
NetmapLookupDepth value. Behavior for default values (zero or missing) left
unchanged.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
@alexvanin alexvanin merged commit 1e170c3 into nspcc-dev:master Jan 12, 2021
@cthulhu-rider cthulhu-rider deleted the feature/234-prev-epoch-dive branch January 26, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality neofs-storage Storage node application issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants