Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept oid.Address into client.PrmObjectGet #404

Closed
roman-khimov opened this issue Apr 27, 2023 · 3 comments · Fixed by #408
Closed

Accept oid.Address into client.PrmObjectGet #404

roman-khimov opened this issue Apr 27, 2023 · 3 comments · Fixed by #408
Assignees
@smallhive
Labels
enhancement Improving existing functionality
Milestone
v1.0.0-rc9

Comments

@roman-khimov
Copy link
Member 

var getPrm client.PrmObjectGet
getPrm.FromContainer(addr.Container())
getPrm.ByID(addr.Object())

It could easily be getPrm.ByAddress(addr).
@roman-khimov roman-khimov added the enhancement Improving existing functionality label Apr 27, 2023
@roman-khimov roman-khimov added this to the v1.0.0-rc9 milestone Apr 27, 2023
@roman-khimov
Copy link
Member Author

Same thing with client.PrmObjectRange. Maybe in some other cases as well.

And client.PrmObjectRange could accept object.Range also.

@roman-khimov
Copy link
Member Author

client.PrmObjectHash

@roman-khimov
Copy link
Member Author

Related to nspcc-dev/neo-go#2995.

smallhive added a commit that referenced this issue May 4, 2023
@smallhive
client: Accept oid.Address into PrmObjectHash, PrmObjectDelete, PrmOb…
f3c9935 
…jectGet

close #404

Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
@smallhive smallhive linked a pull request May 4, 2023 that will close this issue
Accept oid.Address into client.PrmObjectGet, PrmObjectHash, PrmObjectDelete #408
Merged
smallhive added a commit that referenced this issue May 4, 2023
@smallhive
client: Accept oid.Address into PrmObjectHash, PrmObjectDelete, PrmOb…
c3454a1 
…jectGet

close #404

Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
smallhive added a commit that referenced this issue May 5, 2023
@smallhive
client: Accept oid.Address into PrmObjectHash, PrmObjectDelete, PrmOb…
5f2f405 
…jectGet

close #404

Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
smallhive added a commit that referenced this issue May 5, 2023
@smallhive
client: Accept oid.Address into PrmObjectHash, PrmObjectDelete, PrmOb…
86e115e 
…jectGet

close #404

Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
smallhive added a commit that referenced this issue May 5, 2023
@smallhive
client: Accept oid.Address into PrmObjectHash, PrmObjectDelete, PrmOb…
3f603dc 
…jectGet

close #404

Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smallhive smallhive

Labels
enhancement Improving existing functionality
Projects
None yet
Milestone
v1.0.0-rc9
Development

Successfully merging a pull request may close this issue.

Accept oid.Address into client.PrmObjectGet, PrmObjectHash, PrmObjectDelete nspcc-dev/neofs-sdk-go
2 participants
@smallhive @roman-khimov