NeoFS SDK update #2995
Merged
NeoFS SDK update #2995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using _very_ old version, so there is a number of changes, including: * fix for unlimited reads * UTF-8 check for HTTP requests Signed-off-by: Roman Khimov <roman@nspcc.ru>
Codecov Report
@@ Coverage Diff @@
## master #2995 +/- ##
==========================================
- Coverage 84.74% 84.63% -0.11%
==========================================
Files 328 328
Lines 43105 43164 +59
==========================================
+ Hits 36528 36532 +4
- Misses 5088 5143 +55
Partials 1489 1489
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AnnaShaleva
reviewed
Apr 28, 2023
go.uber.org/atomic deprecated CAS methods in version 1.10 (that introduced CompareAndSwap), so we need to fix it. Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
force-pushed
the
neofs-sdk-update
branch
from
8342bde
to
0a160ee
Compare
Hmm, fixed. |
AnnaShaleva
approved these changes
Apr 28, 2023
There was a problem hiding this comment.
And now the Linter job is failing due to the lack of #2996.
cthulhu-rider
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
NeoGo using pre-1.0.0-rc.1 SDK (some version from 2022.01.13!)
Solution
Update to 1.0.0-rc.8.