Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alternative ALT behaviour #268

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Alternative ALT behaviour #268

wants to merge 2 commits into from

Commits on Aug 17, 2022

  1. Alternative ALT behaviour 

    Makes the following changes to the keymap:

1.
Remove all instances where [ALT]+['key'] and ['key'] both map to the same calculator key, freeing up those key combinations for something more useful.

Reasoning: No one is going to press [Alt]+['key'] when it does the same thing as just ['key'], so it is a waste to have it as such, and there are better things that can be done with those key combinations.

This also fixes the following conflict by removing line 150, making [Alt]+[-] map only to '(-)' (negation):
line 103:        ,{Qt::Key_Minus | ALT, keymap::neg}
line 150:        ,{Qt::Key_Minus | ALT, keymap::minus}

2.
Add instances where mappings using symbols made (on US keyboards) by typing [Shift]+['key'] are also mapped to [Alt]+['key'], in the same way as [Alt]+[2] and [@] are both assigned to the 'x^2' calculator key, and [Alt]+[=] and [+] are both assigned to the '+' calculator key, already.

Reasoning:
Since [Shift] = 'shift' on calculator, it would (arguably) be better to not have to use [Shift] outside of the calculator's usage as it can cause unintended problems.
    @eyeonus
    eyeonus committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    ac1657c View commit details
    Browse the repository at this point in the history

  2. Note additional conflicts in keymappings 

    Noticed some mappings that, at least on Windows boxen, are in conflict with the keyboard shortcuts for the 'Emulation' and 'Flash' menubar items.

For reference to any reading this that are unfamiliar, if a letter in a menubar item is underlined, then pressing the [Alt] key while also pressing the key of the underlined letter will cause that particular menuitem to expand, highlighting the first item in its submenu. Firebird has the following shortcuts of this type configured: [E]->'Emulation', [T]->'Tools', [N]->'Snapshot', [F]->'Flash', and [U]->'About'. The 'Docks' menubar item does not have a shortcut assigned to it.

Fortunately, both of the conflicts have alternative mappings as well, so removing these lines is of minimal negative impact.

Unfortunately, this person has no suggestions for a better mapping, so changing these lines rather than removing them may be difficult.
    @eyeonus
    eyeonus committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    4a1112f View commit details
    Browse the repository at this point in the history