Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add findSync #41

Merged
merged 1 commit into from
Aug 16, 2016
Merged

[WIP] Add findSync #41

merged 1 commit into from
Aug 16, 2016

Conversation

robinjmurphy
Copy link
Collaborator

Work in progress findSync for discussion #38

Started by just copying the necessary async methods.

@coveralls
Copy link

coveralls commented Aug 3, 2016 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 2ba05d3 on robinjmurphy:sync into 0315356 on nspragg:master.

nspragg
nspragg reviewed Aug 4, 2016
View reviewed changes
src/filehound.js
return files.isDirectory(file) ? this._search(root, file) : file;
})
.reduce(flatten, [])
.filter((file) => {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should also add events: this.emit('match', file);

@nspragg nspragg merged commit 03757bc into nspragg:master Aug 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@robinjmurphy @coveralls @nspragg