reader: add Configure() #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I refactored this to take a string "key" and an I think this approach is more generally useful than taking a simplejson object regardless of what happens in nsqio/nsq#267. It can be easily wrapped by something that walks a JSON tree and sets individual keys. It also adds per-key error handling. |
takes a key as string and value as interface and attempts to coerce the value into the appropriate format/type based on the specified key.
3 tasks
sthulb
pushed a commit
to HailoOSS/go-nsq
that referenced
this pull request
Sep 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this makes it easy to use a JSON object to configure all options of the reader