nsqd: add support for customise output-buffer-timeout #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @mreiferson @ploxiln |
mreiferson
reviewed
Jan 15, 2019
apps/nsqd/nsqd.go
Outdated
| @@ -117,6 +117,7 @@ func nsqdFlagSet(opts *nsqd.Options) *flag.FlagSet { | |||
| flagSet.Int64("max-rdy-count", opts.MaxRdyCount, "maximum RDY count for a client") | |||
| flagSet.Int64("max-output-buffer-size", opts.MaxOutputBufferSize, "maximum client configurable size (in bytes) for a client output buffer") | |||
| flagSet.Duration("max-output-buffer-timeout", opts.MaxOutputBufferTimeout, "maximum client configurable duration of time between flushing to a client") | |||
| flagSet.Duration("output-buffer-timeout", opts.OutputBufferTimeout, "server configurable duration of time between flushing to a client") | |||
There was a problem hiding this comment.
let's rename the help text here to:
default duration of time between flushing data to clients
There was a problem hiding this comment.
@mreiferson Done. PTAL.
|
I'm OK with this, thanks for the PR @andyxning! |
mreiferson
changed the title
andyxning
force-pushed
the
add_support_for_customise_output-buffer-timeout
branch
from
e74248e
to
1de9c13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for customising server output-buffer-timeout default value.
We have encountered with a single nsqd instance with more than 40k connections. With a default 250ms output buffer timeout we have a high cpu usage. After customising it with 500ms, the CPU
usage drops about 10%.