Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use godep for builds #266

Merged
merged 1 commit into from
Oct 15, 2013
Merged

use godep for builds #266

merged 1 commit into from
Oct 15, 2013

Conversation

mreiferson
Copy link
Member

this is one option for addressing the reproducible build problem. I personally find it to be a simple, elegant, solution. See more information at https://github.com/kr/godep

@mreiferson
Copy link
Member Author

Unfortunately, without jumping through hoops, godep does not support go1.0.3, see tools/godep#7

Gonna need to see how that resolves before proceeding...

@mreiferson
Copy link
Member Author

OK, to update this PR, the idea is that we'd like to move forward and get this in despite the fact that upstream changes have once again caused issues building godep with go1.0.x.

End users have a few options...

  1. download our pre-built binaries for the OS/arch/go version
  2. one-liner patch code.google.com/p/go.tools/go/vcs like we do in the .travis.yml in this PR and then build and use godep
  3. satisfy the dependencies and build manually using the revisions listed in the Godeps file (building NSQ binaries doesn't require godep, just our makefile and shell scripts won't be usable)

So really this change primarily affects developers of NSQ, not end-users.

@mreiferson
Copy link
Member Author

merge me @jehiah

jehiah added a commit that referenced this pull request Oct 15, 2013
@jehiah jehiah merged commit 4b5b045 into nsqio:master Oct 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants