Skip to content
This repository has been archived by the owner on Feb 26, 2019. It is now read-only.

go 1.0.x support #7

Merged
merged 2 commits into from
Oct 8, 2013
Merged

go 1.0.x support #7

merged 2 commits into from
Oct 8, 2013

Conversation

mreiferson
Copy link
Contributor

Unfortunately, due to the dependency on code.google.com/p/go.tools/go/vcs, godep cannot be built w/ go versions prior to 1.1.

$ go get github.com/kr/godep
# code.google.com/p/go.tools/go/vcs
../../../code.google.com/p/go.tools/go/vcs/discovery.go:20: function ends without a return statement
../../../code.google.com/p/go.tools/go/vcs/discovery.go:31: function ends without a return statement

I'm not sure if it was your intention to support only go 1.1+, but it would be nice if this was usable on the lowest common denominator.

It's unlikely that they'll accept a patch to resolve the above issues, and it seems like it is just used to detect what VCS each import uses, right? Would you consider a patch which eliminates this external dependency so that godep can be used with older go installations?

@mreiferson
Copy link
Contributor Author

or perhaps build tags to support an older implementation for go1.0.x?

@mreiferson
Copy link
Contributor Author

FYI, I took a shot to see if we can get upstream to resolve this:

https://codereview.appspot.com/14283043/

@mreiferson
Copy link
Contributor Author

closing, got that CL merged

@mreiferson mreiferson closed this Oct 4, 2013
@mreiferson mreiferson reopened this Oct 4, 2013
@mreiferson
Copy link
Contributor Author

I spoke too soon, this needed one minor tweak.

@mreiferson
Copy link
Contributor Author

@kr any thoughts on this change?

@kr
Copy link
Member

kr commented Oct 8, 2013

This looks great. I don't want to reimplement package vcs.
We use it for a few things:

  • detect which VCS to use
  • find the repo root
  • find the remote url

Doing these things correctly means matching the go tool's
behavior, including everything described in go help remote.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants