installing improvements #46

Merged
merged 2 commits into from Oct 8, 2012

Projects

None yet

3 participants

@mreiferson
Member

make it a bit easier cc @jehiah

@jehiah jehiah commented on the diff Oct 6, 2012
install.sh
+cd nsqd
+go build
+echo " installing nsqd in $DEST"
+cp nsqd $DEST
+
+echo "building nsqlookupd..."
+cd ../nsqlookupd
+go build
+echo " installing nsqlookupd in $DEST"
+cp nsqlookupd $DEST
+
+echo "building nsqadmin..."
+cd ../nsqadmin
+go build
+echo " installing nsqadmin in $DEST"
+cp nsqadmin $DEST
@jehiah
jehiah Oct 6, 2012 NSQ member

nsqadmin is slightly more complicated because we need to copy the templates somewhere. Ideas on where that should/would/could go?

@mreiferson
mreiferson Oct 6, 2012 NSQ member

I suppose /usr/local/share makes the most sense (read-only architecture independent data) by default?

also, we should either prompt for directories (and provide defaults) or provide command line options (with defaults)... any preference? Arguably we're delving into Makefile like functionality that perhaps means thats what it should be...

@jehiah
jehiah Oct 6, 2012 NSQ member

it currently uses a command line option with a default of a relative "templates" directory so that it's runnable w/o specifying that parameter from the command line when run from the source tree. We could implement some sort of search path, or just make people specify the full path.

I disappointed with the lack of standard ways to bundle the templates into the binary (without making them raw strings in a go file).

@mreiferson
Member

ready @jehiah

@jehiah
Member
jehiah commented Oct 8, 2012

nice updated on the template path handling

@jehiah jehiah merged commit 830b3c8 into nsqio:master Oct 8, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment