installing improvements #46
Conversation
| cd ../nsqadmin | ||
| go build | ||
| echo " installing nsqadmin in $DEST" | ||
| cp nsqadmin $DEST |
There was a problem hiding this comment.
nsqadmin is slightly more complicated because we need to copy the templates somewhere. Ideas on where that should/would/could go?
There was a problem hiding this comment.
I suppose /usr/local/share makes the most sense (read-only architecture independent data) by default?
also, we should either prompt for directories (and provide defaults) or provide command line options (with defaults)... any preference? Arguably we're delving into Makefile like functionality that perhaps means thats what it should be...
There was a problem hiding this comment.
it currently uses a command line option with a default of a relative "templates" directory so that it's runnable w/o specifying that parameter from the command line when run from the source tree. We could implement some sort of search path, or just make people specify the full path.
I disappointed with the lack of standard ways to bundle the templates into the binary (without making them raw strings in a go file).
|
ready @jehiah |
|
nice updated on the template path handling |
restore SetMaxInFlight dropped in refactoring
make it a bit easier cc @jehiah