Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nsqd: fix diskqueue benchmark test, maxMsgSize too small #808

Merged
merged 1 commit into from
Nov 6, 2016
Merged

nsqd: fix diskqueue benchmark test, maxMsgSize too small #808

merged 1 commit into from
Nov 6, 2016

Conversation

yejingx
Copy link
Contributor

@yejingx yejingx commented Nov 4, 2016

BenchmarkDiskQueueGet4096 will put invalid messages if maxMsgSize is 1<<10.

@judwhite
Copy link
Contributor

judwhite commented Nov 5, 2016

Nice catch. Checking err from here might've revealed this sooner.

@mreiferson
Copy link
Member

thanks!

@mreiferson mreiferson merged commit c4e2add into nsqio:master Nov 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yejingx @judwhite @mreiferson