Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nsqd: bound MPUB messages to derived limit #835

Merged
merged 1 commit into from
Dec 28, 2016
Merged

nsqd: bound MPUB messages to derived limit #835

merged 1 commit into from
Dec 28, 2016

Conversation

mreiferson
Copy link
Member

fixes #822

@mreiferson mreiferson added the bug label Dec 28, 2016
jehiah
jehiah approved these changes Dec 28, 2016
View reviewed changes
Copy link
Member

@jehiah jehiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but do we also need to check if we exceed maxBodySize as we read messages in the MPUB?

@mreiferson
Copy link
Member Author

@jehiah handled by callers of readMPUB, e.g. https://github.com/nsqio/nsq/pull/835/files#diff-12a30208ec1e011f7cd53fe10c77575cR816

@mreiferson mreiferson merged commit 866aa08 into nsqio:master Dec 28, 2016
@mreiferson mreiferson deleted the max-messages branch December 28, 2016 22:29
@mreiferson mreiferson mentioned this pull request Dec 28, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jehiah jehiah jehiah approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nsqd: panic when sending garbage to binary /mpub
2 participants
@mreiferson @jehiah