Implementing automated versioning #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also fixes #6 as the timestamp precision and bits are now constant parameters |
…move 'const EPOCH' from 'BinaryId'
…; added some compile-time validation for consts, and tests to verify the validation
nstilt1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to create a relatively-automated MasterKey, where versions and EPOCH times can be routinely increased. This PR will fix #4, and it will fix #1, with the exception of providing ways to change signature algorithms and KDF algorithms (unless I can get that sorted out).
There are several requirements for the MasterKey:
keyless_ids, but for any expiring key ID, if the version is too old to have possibly been generated with a specific version, the key needs to be invalidated based on the version.